RFR: 2331: Improve review notes [v2]
Pavel Rappo
prappo at openjdk.org
Tue Jul 23 09:33:14 UTC 2024
> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
>
> - 🔄 Re-review required ...
> - ⚠️ Review applies to ...
>
> That note may confuse or draw unneeded attention to the PR body.
>
> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
>
> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312
Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
- Avoid emojis and "required" when a PR is ready
- Re-indent code
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1679/files
- new: https://git.openjdk.org/skara/pull/1679/files/e05e390a..415b5984
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1679&range=01
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1679&range=00-01
Stats: 55 lines in 2 files changed: 24 ins; 0 del; 31 mod
Patch: https://git.openjdk.org/skara/pull/1679.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1679/head:pull/1679
PR: https://git.openjdk.org/skara/pull/1679
More information about the skara-dev
mailing list