RFR: 2272: Improve issuestitleCheck [v2]

David Holmes dholmes at openjdk.org
Mon Jun 3 05:19:01 UTC 2024


On Fri, 31 May 2024 23:38:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> I was thinking we should ask if David Holmes has any thoughts about this list...
>
> No I think it should just be removed. Otherwise we will end up having to list every executable in the JDK as well as basically every build tool used when building it, and even so, that would be a very JDK project specific list of executables. Several of those would also overlap with words that we would want to flag, e.g. "make", "java".

Honestly, while I appreciate the attempt to improve this, I don't see what the rules are trying to achieve. This is not a grammatical context, and the no-period rule means this is not expected to be a sentence; and we are not trying to enforce title-case so ... what exactly does "Should start with a capital" achieve - especially with all the noted, if not programmed, exceptions?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1623794185


More information about the skara-dev mailing list