RFR: 2258: Skara won't allow "/csr unneeded" after CSR has been Withdrawn

[Erik Joelsson]

On Mon, 3 Jun 2024 20:45:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When processing "/csr unneeded" command, skara bot will use pr body to check if there are any open csrs  associated with the pr. However, there is a race condition here, after the user withdraws the csr, the bot needs some time to update the pr body. Therefore, if the user issues "/csr unneeded" immediately after withdrawing the csr in JBS, it's very likely that the bot would use stale pr body and make the wrong judgement.
> 
> I think the solution here is that when the bot finds existing csrs, the bot should fetch the csrs from JBS and double check if the csr issue is still open. Since the case is not very common, I believe this won't add many GET requests.

I think this looks good. You aren't adding a new test so have you verified this in some other way or are the existing tests enough to cover it?

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1654#pullrequestreview-2096300478