RFR: 2286: Git jcheck --working-tree/--staged not compatible with some checks [v2]

Zhao Song zsong at openjdk.org
Fri Jun 7 18:08:55 UTC 2024


> In [SKARA-1690](https://bugs.openjdk.org/browse/SKARA-1690), I tried to make SKARA CLI able to run jcheck on the diff in current working tree. But seems like this feature is not compatible with some jchecks like problemLists check.
> 
> When jcheck is checking staged or working-tree, I think there is no point to run some checks that require real commit message. Therefore I disabled the checks and Skara CLI will print a prompt to user.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1658/files
  - new: https://git.openjdk.org/skara/pull/1658/files/229e5a5d..da514368

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1658&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1658&range=00-01

  Stats: 26 lines in 2 files changed: 13 ins; 9 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1658.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1658/head:pull/1658

PR: https://git.openjdk.org/skara/pull/1658


More information about the skara-dev mailing list