[External] : Re: Review and Commit links for backport branches
Volker Simonis
volker.simonis at gmail.com
Mon Jun 10 16:32:19 UTC 2024
Done: https://bugs.openjdk.org/browse/SKARA-2292
On Mon, Jun 10, 2024 at 5:57 PM Kevin Rushforth
<kevin.rushforth at oracle.com> wrote:
>
> That sounds good then. Can you file a JBS Enhancement request in the
> SKARA project, "bot" component? Erik can then decide whether / how to
> proceed.
>
> -- Kevin
>
>
> On 6/10/2024 8:43 AM, Volker Simonis wrote:
> > On Mon, Jun 10, 2024 at 5:31 PM Kevin Rushforth
> > <kevin.rushforth at oracle.com> wrote:
> >> This would just affect the link text in the issue links section, right?
> >> If we do this, I would just use the branch name, so "jdk23" not "23",
> > Yes, just the text. We can't change the link, because that's for the
> > "jdk" repository in both cases.
> >
> > Any syntax would be fine for me (jdk:23, jdk:jdk23 or jdk23) as long
> > as the version could easily be identified.
> >
> >> but this seems like a reasonable Enhancement request to me, but Erik
> >> will need to weigh in on this.
> >>
> >> -- Kevin
> >>
> >>
> >> On 6/10/2024 8:24 AM, Volker Simonis wrote:
> >>> Hi,
> >>>
> >>> After the JDK stabilization process has moved from using dedicated
> >>> repositories to using branches in the https://git.openjdk.org/jdk
> >>> repository, I noticed that Commit, Review and PullRequest links for
> >>> the master repository are now indistinguishable from the corresponding
> >>> downport links. E.g. from https://bugs.openjdk.org/browse/JDK-8333722:
> >>>
> >>> Commit openjdk/jdk/5f9d3e3a
> >>> Commit openjdk/jdk/fdbc2b24
> >>>
> >>> Review openjdk/jdk/19578
> >>> Review openjdk/jdk/19622
> >>>
> >>> Previously, such links were easily distinguishable because they were
> >>> for different repositories.
> >>>
> >>> I wonder if it would be possible to somehow add the branch name to the
> >>> link description, if it is not master, in order to make it more clear
> >>> what they refer to. E.g.
> >>>
> >>> Commit openjdk/jdk/5f9d3e3a
> >>> Commit openjdk/jdk:23/fdbc2b24
> >>>
> >>> Review openjdk/jdk/19578
> >>> Review openjdk/jdk:23/19622
> >>>
> >>> Thank you and best regards,
> >>> Volker
>
More information about the skara-dev
mailing list