RFR: 2295: Rephrase error messages in PullRequestCheckIssueVisitor [v2]

[Erik Joelsson]

On Fri, 14 Jun 2024 21:25:55 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> PullRequestCheckIssueVisitor is responsible for generating error messages when jcheck fails. Currently, jcheck could be configured as different severity(error or warning). However, when generating error messages for some jchecks like binary check, the error message would be like "Binary files are not allowed", so if the binary check was configured as warning, this message seems too hard. Therefore, I would like to rephrase some error messages.
>> 
>> Erik suggested that we should generate different messages depending on the severity, but I think maybe it's unnecessary. The user does not need to judge the severity depending on the error message. The user only needs to check which section is the message under(Integration Blocker or Warning).
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Nice, I like these more nuanced messages.

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1660#pullrequestreview-2119369767