Integrated: 2295: Rephrase error messages in PullRequestCheckIssueVisitor

[Zhao Song]

On Thu, 13 Jun 2024 23:15:15 GMT, Zhao Song <zsong at openjdk.org> wrote:

> PullRequestCheckIssueVisitor is responsible for generating error messages when jcheck fails. Currently, jcheck could be configured as different severity(error or warning). However, when generating error messages for some jchecks like binary check, the error message would be like "Binary files are not allowed", so if the binary check was configured as warning, this message seems too hard. Therefore, I would like to rephrase some error messages.
> 
> Erik suggested that we should generate different messages depending on the severity, but I think maybe it's unnecessary. The user does not need to judge the severity depending on the error message. The user only needs to check which section is the message under(Integration Blocker or Warning).

This pull request has now been integrated.

Changeset: 19a83f28
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/19a83f283f7434cf000d13ad419e89fc55f2a9fa
Stats:     21 lines in 1 file changed: 11 ins; 0 del; 10 mod

2295: Rephrase error messages in PullRequestCheckIssueVisitor

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1660