RFR: 2297: CSRs for OpenJDK 8u backports not being picked up

[Erik Joelsson]

On Thu, 20 Jun 2024 18:00:02 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, the version matching logic in `Backports::findClosetIssue` and `Backports::findIssue` differs, causing the skara bot fail to find CSRs for some issues.
> 
> In this patch, I'm trying to unify the version matching logic between the two methods. I couldn't find a good way to reuse the previous methods(`Backports::matchVersion`, `Backports::matchOptPoolVersion`, `Backports::matchPoolVersion`, `Backports::matchScratchVersion`), so I changed the interface of the methods.

Marked as reviewed by erikj (Lead).

jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 172:

> 170:                 .filter(Backports::isNonScratchVersion)
> 171:                 .toList();
> 172:         return nonScratch.size() == 0;

Maybe use `noneMatch`?

-------------

PR Review: https://git.openjdk.org/skara/pull/1661#pullrequestreview-2135157685
PR Review Comment: https://git.openjdk.org/skara/pull/1661#discussion_r1650655125