RFR: 2297: CSRs for OpenJDK 8u backports not being picked up [v2]

Zhao Song zsong at openjdk.org
Mon Jun 24 19:46:33 UTC 2024


On Mon, 24 Jun 2024 17:07:29 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, the version matching logic in `Backports::findClosetIssue` and `Backports::findIssue` differs, causing the skara bot fail to find CSRs for some issues.
>> 
>> In this patch, I'm trying to unify the version matching logic between the two methods. I couldn't find a good way to reuse the previous methods(`Backports::matchVersion`, `Backports::matchOptPoolVersion`, `Backports::matchPoolVersion`, `Backports::matchScratchVersion`), so I changed the interface of the methods.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1661#issuecomment-2187282500


More information about the skara-dev mailing list