RFR: 2307: PullRequestCheckIssueVisitor generates only one error message per Issue type

Erik Joelsson erikj at openjdk.org
Tue Jun 25 20:28:41 UTC 2024


On Mon, 24 Jun 2024 22:31:58 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When testing [SKARA-2303](https://bugs.openjdk.org/browse/SKARA-2303), I found that even when there are few binary files in a diff, the pr body only warns about one binary file. Then I found that in PullRequestCheckIssueVisitor, we are using HashMap<Check, String> to store the error messages, so if there are few issues with the same type, the HashMap is only able to save the last error message.

I meant 50 total.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1662#issuecomment-2189908557


More information about the skara-dev mailing list