RFR: 2189: Mark command as handled when JCheckConfiguration is missing or invalid in PullRequestCommandWorkItem [v3]

[Erik Joelsson]

On Mon, 4 Mar 2024 18:21:44 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Recently, we found that the skara bot keeps trying to process /open command in this pr https://github.com/openjdk/jdk8u-dev/pull/393
>> 
>> After investigation, we found that this pr is a dependent pr and this pr was closed before the parent pr(https://github.com/openjdk/jdk8u-dev/pull/392) got integrated, so this dependent pr didn't get retargeted.
>> 
>> Skara bot was trying to process the command but the bot couldn't find jcheck configuration in the target branch because the target is already deleted. And when the jcheck configuration is invalid or missing in PullRequestCommandWorkItem, RuntimeException would be thrown, causing the bot to repeatedly process the command. This behavior is wrong because when jcheck configuration is missing or invalid, it wouldn't recover automatically. In this case, the bot should just notice the user what problem it found and mark the command as handled to prevent the bot from being stuck in a loop.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix issues

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1616#pullrequestreview-1915048661