RFR: 2190: Setting maximum size limit for PR diff in generating Webrev [v2]

Zhao Song zsong at openjdk.org
Thu Mar 7 19:14:04 UTC 2024


> https://github.com/openjdk/tsan/pull/17, there are more than 5000 commits in this pr and mlbridge bot was trying to generate the webrev. The generation of webrev was successful but the webrev file was too big and exceeded GitHub's file size limit.
> 
> So as ErikJ suggested, if the diff of the pr is too large, we shouldn't generate webrev for it.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1617/files
  - new: https://git.openjdk.org/skara/pull/1617/files/2824b3f3..5e7b7111

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1617&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1617&range=00-01

  Stats: 11 lines in 3 files changed: 3 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1617.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1617/head:pull/1617

PR: https://git.openjdk.org/skara/pull/1617


More information about the skara-dev mailing list