RFR: 2190: Setting maximum size limit for PR diff in generating Webrev [v2]

Erik Joelsson erikj at openjdk.org
Fri Mar 8 18:37:46 UTC 2024


On Thu, 7 Mar 2024 19:14:04 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> https://github.com/openjdk/tsan/pull/17, there are more than 5000 commits in this pr and mlbridge bot was trying to generate the webrev. The generation of webrev was successful but the webrev file was too big and exceeded GitHub's file size limit.
>> 
>> So as ErikJ suggested, if the diff of the pr is too large, we shouldn't generate webrev for it.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Test comment, please ignore.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1617#issuecomment-1986210804


More information about the skara-dev mailing list