RFR: 2198: Backport PRs should check if a CSR is required [v2]

[Erik Joelsson]

On Thu, 21 Mar 2024 20:10:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make CSR process link a constant
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1580:
> 
>> 1578:                         "This backport might also need a CSR. `csr` label will be added to this PR.\n" +
>> 1579:                         "Please go through the [CSR](" + CSR_PROCESS_LINK +
>> 1580:                         ") process or using command `csr unneeded` to remove the CSR requirement.");
> 
> There is no need to use single newlines, they will just be ignored when the comment is formatted anyway.
> 
> Suggestion:
> 
>                 pr.addComment("At least one of the issues associated with this backport has a resolved " +
>                         "[CSR](" + CSR_PROCESS_LINK + ") for a different version. As this means that this " +
>                         "backport may also need a CSR, the `csr` label is being added to this pull request " +
>                         "to signal this potential requirement. The command `/csr unneeded` can be used to " + 
>                         "remove the label in case a CSR is not needed.");

If something goes wrong in CheckRun after posting this comment and before the labels are updated, we run the risk of posting this comment multiple times. We should add a marker in the comment and check that we haven't posted one before.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1623#discussion_r1534615355