RFR: 2198: Backport PRs should check if a CSR is required [v6]

Zhao Song zsong at openjdk.org
Fri Mar 22 20:06:18 UTC 2024


On Fri, 22 Mar 2024 19:55:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comment
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1650:
> 
>> 1648:      * Constructs a map from main issue ID to all CSR links.
>> 1649:      */
>> 1650:     private Map<String, List<Link>> issueToCsrLinksMap(Map<Issue, Optional<IssueTrackerIssue>> regularIssuesMap) {
> 
> Looking at this some more, I think it would make more sense if we made the map from issue ID to `List<IssueTrackerIssue>`. Both consumers of this map map to the linked Issue anyway.
> Suggestion:
> 
>     private Map<String, List<IssueTrackerIssue>> issueToAllCsrsMap(Map<Issue, Optional<IssueTrackerIssue>> regularIssuesMap) {

Make sense.  Will change it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1623#discussion_r1536137314


More information about the skara-dev mailing list