RFR: 2214: Require CSR again if all of the CSRs are withdrawn in a Backport CSR PR

Erik Joelsson erikj at openjdk.org
Tue Mar 26 20:18:43 UTC 2024


On Tue, 26 Mar 2024 18:18:51 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When testing [SKARA-2198](https://bugs.openjdk.org/browse/SKARA-2198), I found that there is a bug.
> 
> When determining if the bot should add the csr label to a backport CSR pr, if the bot found the pr is already associated with any CSR(regardless if it's withdrawn or not), then the bot would not add the csr label.
> 
> This is a bug. A user could create a CSR for this pr and withdraw it, then the user could bypass the CSR request.
> 
> The bot should ignore withdrawn CSRs in this case.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1625#pullrequestreview-1961619139


More information about the skara-dev mailing list