RFR: 2213: Record reviewers with stale reviews in the commit message

[Erik Joelsson]

On Wed, 27 Mar 2024 22:18:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As a user requested, when `ignoreStaleReview` is enabled in a repo, Skara bot should still record reviewers with stale reviews in the commit message.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java line 83:

> 81: 
> 82:         if (manualReviewersAndStaleReviewers) {
> 83:             reviewers.addAll(Reviewers.reviewers(currentUser, comments));

In the old code, if someone did a non approved verdict review and was added manually as a reviewer, they would not get reviewer credit. With this change, we unconditionally add all manual reviewers. That is probably how most people would expect the command to work though. @kevinrushforth do you have an opinion here?

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java line 91:

> 89:                     }
> 90:                 }
> 91:                 reviewers.addAll(reviewerNames(staleReviews, namespace));

I think all of this could be replaced with just adding `manualReviewersAndStaleReviewers` to the filter condition at line 76.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1542916085
PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1542911977