RFR: 2213: Record reviewers with stale reviews in the commit message

Zhao Song zsong at openjdk.org
Thu Mar 28 16:43:50 UTC 2024


On Thu, 28 Mar 2024 16:29:08 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Yes, it seems expected that all manually credited reviewers would be added regardless of whether or not they had also done a non-approving review. I presume there will be no change in behavior in the (vast majority) of cases where the PR author has not used the `/reviewer credit` command: only approving reviewers should be added and not those who had done a non-approving review?
>
> Correct, that case is unchanged. Since you agree with the new behavior, I'm also ok with it. I did find the old one a bit odd.

I was thinking the old one is a bug... So I changed it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1543290909


More information about the skara-dev mailing list