RFR: 2213: Record reviewers with stale reviews in the commit message
Zhao Song
zsong at openjdk.org
Thu Mar 28 17:15:07 UTC 2024
On Thu, 28 Mar 2024 16:47:40 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java line 91:
>>
>>> 89: }
>>> 90: }
>>> 91: reviewers.addAll(reviewerNames(staleReviews, namespace));
>>
>> I think all of this could be replaced with just adding `manualReviewersAndStaleReviewers` to the filter condition at line 76.
>
> But the review with non-existing commit(e.g. after a reviewer approved the pr, the author force pushed) or the review made when the pr targets a different branch will be filtered out.
Or we can add `manualReviewersAndStaleReviewers` to the filter condition at line 74,75,76
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1543339735
More information about the skara-dev
mailing list