RFR: 2213: Record reviewers with stale reviews in the commit message

Erik Joelsson erikj at openjdk.org
Thu Mar 28 17:59:57 UTC 2024


On Thu, 28 Mar 2024 17:12:57 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> But the review with non-existing commit(e.g. after a reviewer approved the pr, the author force pushed) or the review made when the pr targets a different branch will be filtered out.
>
> Or we can add `manualReviewersAndStaleReviewers` to the filter condition at line 74,75,76

Ah you are right, ignore this suggestion.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1543400623


More information about the skara-dev mailing list