From zsong at openjdk.org Mon May 6 17:03:52 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 6 May 2024 17:03:52 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v3] In-Reply-To: <3rnG3w4iXYWydAwmYEXvwMXesC7SzveuGYZGVJpy480=.3bf184c7-7586-4df1-aec3-760c753d7af1@github.com> References: <3rnG3w4iXYWydAwmYEXvwMXesC7SzveuGYZGVJpy480=.3bf184c7-7586-4df1-aec3-760c753d7af1@github.com> Message-ID: <5FWD9xYJuOwXhpsr-d1NLPlgtn_UaPiqfww1WRbvhu0=.8e4dbab9-d796-4ed1-91b5-ba9700a3e5fc@github.com> On Tue, 30 Apr 2024 22:29:04 GMT, Zhao Song wrote: >> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. >> >> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > fix test This PR is ready for review. Could someone please review it? ping... ------------- PR Comment: https://git.openjdk.org/skara/pull/1638#issuecomment-2096506735 From erikj at openjdk.org Mon May 6 17:26:24 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 6 May 2024 17:26:24 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v3] In-Reply-To: <5FWD9xYJuOwXhpsr-d1NLPlgtn_UaPiqfww1WRbvhu0=.8e4dbab9-d796-4ed1-91b5-ba9700a3e5fc@github.com> References: <3rnG3w4iXYWydAwmYEXvwMXesC7SzveuGYZGVJpy480=.3bf184c7-7586-4df1-aec3-760c753d7af1@github.com> <5FWD9xYJuOwXhpsr-d1NLPlgtn_UaPiqfww1WRbvhu0=.8e4dbab9-d796-4ed1-91b5-ba9700a3e5fc@github.com> Message-ID: On Mon, 6 May 2024 17:01:43 GMT, Zhao Song wrote: > This PR is ready for review. Could someone please review it? ping... Sorry, I saw your comment about it not being ready so assumed you would say something when it was. Noticed the draft state change now. ------------- PR Comment: https://git.openjdk.org/skara/pull/1638#issuecomment-2096543929 From erikj at openjdk.org Mon May 6 20:24:33 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 6 May 2024 20:24:33 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v3] In-Reply-To: <3rnG3w4iXYWydAwmYEXvwMXesC7SzveuGYZGVJpy480=.3bf184c7-7586-4df1-aec3-760c753d7af1@github.com> References: <3rnG3w4iXYWydAwmYEXvwMXesC7SzveuGYZGVJpy480=.3bf184c7-7586-4df1-aec3-760c753d7af1@github.com> Message-ID: <7wUlqSq20_Lm7lWixsoQ8Wr15rOmg-U9myWETdyCk1w=.06d36ecf-8a1d-4d42-9894-e1a9cbc81b15@github.com> On Tue, 30 Apr 2024 22:29:04 GMT, Zhao Song wrote: >> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. >> >> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > fix test bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 58: > 56: > 57: private void addMessage(Check check, String message, Severity severity, boolean readyForReviewWhenFailedAsError) { > 58: if (severity.equals(Severity.ERROR)) { With enums it's ok and even encouraged to use `==` for comparison. bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 62: > 60: if (this.readyForReview) { > 61: this.readyForReview = readyForReviewWhenFailedAsError; > 62: } This part is rather confusing to try to understand. Maybe we need a separate method for updating the `readyForReview` field, and remove the new parameter `readyForReviewWhenFailedAsError` from this method, to make this interaction clearer? private void setNotReadyForReviewOnError(Severity severity) { if (severity == ERROR) { readyForReview = false; } } This method would be called from the places that used to do `readyForReview = false`. bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 76: > 74: } > 75: > 76: List hiddenMessages() { Maybe rename this to make it clear that it's about errors only, something like `hiddenErrorMessages()`. bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 295: > 293: List messages = new ArrayList<>(); > 294: if (!issue.issuesWithTrailingPeriod().isEmpty()) { > 295: messages.add("Found trailing period in " + String.join(" ,", issue.issuesWithTrailingPeriod())); Shouldn't the join be comma followed with space? Maybe specify that this is in the issue title? Suggestion: messages.add("Found trailing period in issue title for " + String.join(", ", issue.issuesWithTrailingPeriod())); bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 298: > 296: } > 297: if (!issue.issuesWithLeadingLowerCaseLetter().isEmpty()) { > 298: messages.add("Found leading lowercase letter in " + String.join(" ,", issue.issuesWithLeadingLowerCaseLetter())); Suggestion: messages.add("Found leading lowercase letter in issue title for " + String.join(" ,", issue.issuesWithLeadingLowerCaseLetter())); cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 321: > 319: if (!i.issuesWithLeadingLowerCaseLetter().isEmpty()) { > 320: println(i, "Found leading lowercase letter in " + String.join(" ,", i.issuesWithLeadingLowerCaseLetter())); > 321: } Same comment here about wording and joining as above. jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 71: > 69: @Override > 70: public String description() { > 71: return "Issue's title shouldn't have trailing period"; Suggestion: return "Issue's title should be properly formatted"; ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591483750 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591498596 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591487824 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591509427 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591511027 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591513077 PR Review Comment: https://git.openjdk.org/skara/pull/1638#discussion_r1591514159 From zsong at openjdk.org Mon May 6 22:09:01 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 6 May 2024 22:09:01 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v4] In-Reply-To: References: Message-ID: > This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. > > When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: review comment ------------- Changes: - all: https://git.openjdk.org/skara/pull/1638/files - new: https://git.openjdk.org/skara/pull/1638/files/584bcbfe..b02f549e Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1638&range=03 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1638&range=02-03 Stats: 72 lines in 5 files changed: 16 ins; 3 del; 53 mod Patch: https://git.openjdk.org/skara/pull/1638.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1638/head:pull/1638 PR: https://git.openjdk.org/skara/pull/1638 From erikj at openjdk.org Mon May 6 22:52:52 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 6 May 2024 22:52:52 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v4] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 22:09:01 GMT, Zhao Song wrote: >> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. >> >> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > review comment Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1638#pullrequestreview-2041796503 From zsong at openjdk.org Tue May 7 16:21:45 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 16:21:45 GMT Subject: Integrated: 2170: Warn on trailing period in PR titles In-Reply-To: References: Message-ID: On Mon, 15 Apr 2024 22:45:30 GMT, Zhao Song wrote: > This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. > > When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. This pull request has now been integrated. Changeset: 2edf2280 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/2edf2280cbc800a7e578e134d68fe9b33f8e1bd7 Stats: 390 lines in 11 files changed: 283 ins; 0 del; 107 mod 2170: Warn on trailing period in PR titles 2248: Warn on leading lowercase letter in PR titles Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1638 From zsong at openjdk.org Tue May 7 16:21:45 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 16:21:45 GMT Subject: RFR: 2170: Warn on trailing period in PR titles [v4] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 22:09:01 GMT, Zhao Song wrote: >> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid. >> >> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > review comment Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1638#issuecomment-2098838191 From zsong at openjdk.org Tue May 7 21:20:17 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 21:20:17 GMT Subject: RFR: 2254: TestInfoBotWorkItem should handle Runtime Exception Message-ID: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> I created a PR in SKARA(https://github.com/openjdk/skara/pull/1647) and I found the GitHub actions are in the running state for more than about 2 hours. But actually, the GitHub actions are finished(https://github.com/zhaosongzs/skara/actions/runs/8990857032/job/24697152747). From the log, I could see TestInfoBotWorkItem got 500 error when querying the checks for this pr. However, TestInfoBotWorkItem wasn't retried. After investigation, I found TestInfoBotWorkItem doesn't handleRuntimeException. ------------- Commit messages: - SKARA-2254 Changes: https://git.openjdk.org/skara/pull/1648/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1648&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2254 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1648.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1648/head:pull/1648 PR: https://git.openjdk.org/skara/pull/1648 From zsong at openjdk.org Tue May 7 21:44:08 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 21:44:08 GMT Subject: RFR: 2253: No need to check title mismatch between PR and JBS for additional issues Message-ID: Users can use command /issue to associate more issues with a pr. When processing an /issue command, skara bot would add a hidden marker like this "" in a comment. Later, in CheckRun, the pr bot would parse the hidden markers to get all additional issues and use them as keys in regularIssuesMap. The values of regularIssuesMap are jbs issues. Pr bot would check if the issue title matches between the title of the key(title in the hidden marker) and the title of the value(title in the jbs issue). If not, pr bot would add " ?? Title mismatch between PR and JBS." to the issue. This check makes sense for title issue, but not for additional issues because we only display title of jbs issues for additional issues. For example, if I have a pr whose title is "1: Test issue1", and then I use "/issue add 2" to associate another issue with this PR. Pr bot would add a hidden marker "" in a comment. And I would see " Issue TEST-1: Test issue1 TEST-2: Test issue2 " in the pr body. If I update the title of TEST-2 to "Test newIssue2" in JBS. I would see " Issue TEST-1: Test issue1 TEST-2: Test newIssue2( ?? Title mismatch between PR and JBS.) " in the pr body because the jbs issue title is different from the issue title in the hidden marker. The only way to fix it is removing the issue by "/issue remove 2" and then add it again. ------------- Commit messages: - SKARA-2253 Changes: https://git.openjdk.org/skara/pull/1647/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1647&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2253 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1647.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1647/head:pull/1647 PR: https://git.openjdk.org/skara/pull/1647 From erikj at openjdk.org Tue May 7 23:08:34 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 7 May 2024 23:08:34 GMT Subject: RFR: 2254: TestInfoBotWorkItem should handle Runtime Exception In-Reply-To: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> References: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> Message-ID: On Tue, 7 May 2024 21:01:03 GMT, Zhao Song wrote: > I created a PR in SKARA(https://github.com/openjdk/skara/pull/1647) and I found the GitHub actions are in the running state for more than about 2 hours. But actually, the GitHub actions are finished(https://github.com/zhaosongzs/skara/actions/runs/8990857032/job/24697152747). From the log, I could see TestInfoBotWorkItem got 500 error when querying the checks for this pr. However, TestInfoBotWorkItem wasn't retried. After investigation, I found TestInfoBotWorkItem doesn't handleRuntimeException. > > The GitHub actions in https://github.com/openjdk/skara/pull/1647 are done right now because I mentioned that pr in this one. So the pr was updated and triggered a new TestInfoBotWorkItem Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1648#pullrequestreview-2044340612 From erikj at openjdk.org Tue May 7 23:13:11 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 7 May 2024 23:13:11 GMT Subject: RFR: 2253: No need to check title mismatch between PR and JBS for additional issues In-Reply-To: References: Message-ID: On Tue, 7 May 2024 19:03:19 GMT, Zhao Song wrote: > Users can use command /issue to associate more issues with a pr. When processing an /issue command, skara bot would add a hidden marker like this " -- >" in a comment. Later, in CheckRun, the pr bot would parse the hidden markers to get all additional issues and use them as keys in regularIssuesMap. The values of regularIssuesMap are jbs issues. Pr bot would check if the issue title matches between the title of the key(title in the hidden marker) and the title of the value(title in the jbs issue). If not, pr bot would add " ?? Title mismatch between PR and JBS." to the issue. This check makes sense for title issue, but not for additional issues because we only display title of jbs issues for additional issues. > > For example, if I have a pr whose title is "1: Test issue1", and then I use "/issue add 2" to associate another issue with this PR. Pr bot would add a hidden marker "" in a comment. > And I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test issue2 > " > in the pr body. > > If I update the title of TEST-2 to "Test newIssue2" in JBS. > > I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test newIssue2( ?? Title mismatch between PR and JBS.) > " > in the pr body because the jbs issue title is different from the issue title in the hidden marker. > > The only way to fix it is removing the issue by "/issue remove 2" and then add it again. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1647#pullrequestreview-2044346636 From zsong at openjdk.org Tue May 7 23:20:22 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 23:20:22 GMT Subject: RFR: 2254: TestInfoBotWorkItem should handle Runtime Exception In-Reply-To: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> References: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> Message-ID: <6WtkBcREMcnswg0NwE9l_oZNywsjD1O7ndeDCzuFdMU=.d915fea1-8542-4830-a285-854113522ab4@github.com> On Tue, 7 May 2024 21:01:03 GMT, Zhao Song wrote: > I created a PR in SKARA(https://github.com/openjdk/skara/pull/1647) and I found the GitHub actions are in the running state for more than about 2 hours. But actually, the GitHub actions are finished(https://github.com/zhaosongzs/skara/actions/runs/8990857032/job/24697152747). From the log, I could see TestInfoBotWorkItem got 500 error when querying the checks for this pr. However, TestInfoBotWorkItem wasn't retried. After investigation, I found TestInfoBotWorkItem doesn't handleRuntimeException. > > The GitHub actions in https://github.com/openjdk/skara/pull/1647 are done right now because I mentioned that pr in this one. So the pr was updated and triggered a new TestInfoBotWorkItem Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1648#issuecomment-2099462593 From zsong at openjdk.org Tue May 7 23:20:22 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 23:20:22 GMT Subject: Integrated: 2254: TestInfoBotWorkItem should handle Runtime Exception In-Reply-To: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> References: <-pOxeF3gjLiCf9SUyORwHPa0UEgvjwgTjH5BliQjMPU=.aa0a43f6-959e-4e17-8eb7-dfade4e9003c@github.com> Message-ID: <_AvSKt3bfot4auLoqLSC6jJlATOcU98pOM4vlOD1Q9Q=.4efb521c-c83f-4444-8c85-7b3fbe7bbdb9@github.com> On Tue, 7 May 2024 21:01:03 GMT, Zhao Song wrote: > I created a PR in SKARA(https://github.com/openjdk/skara/pull/1647) and I found the GitHub actions are in the running state for more than about 2 hours. But actually, the GitHub actions are finished(https://github.com/zhaosongzs/skara/actions/runs/8990857032/job/24697152747). From the log, I could see TestInfoBotWorkItem got 500 error when querying the checks for this pr. However, TestInfoBotWorkItem wasn't retried. After investigation, I found TestInfoBotWorkItem doesn't handleRuntimeException. > > The GitHub actions in https://github.com/openjdk/skara/pull/1647 are done right now because I mentioned that pr in this one. So the pr was updated and triggered a new TestInfoBotWorkItem This pull request has now been integrated. Changeset: b90bec98 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/b90bec980c6a921ef57d6ca0da0e1140e655e746 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 2254: TestInfoBotWorkItem should handle Runtime Exception Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1648 From zsong at openjdk.org Tue May 7 23:20:40 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 23:20:40 GMT Subject: RFR: 2253: No need to check title mismatch between PR and JBS for additional issues In-Reply-To: References: Message-ID: On Tue, 7 May 2024 19:03:19 GMT, Zhao Song wrote: > Users can use command /issue to associate more issues with a pr. When processing an /issue command, skara bot would add a hidden marker like this " -- >" in a comment. Later, in CheckRun, the pr bot would parse the hidden markers to get all additional issues and use them as keys in regularIssuesMap. The values of regularIssuesMap are jbs issues. Pr bot would check if the issue title matches between the title of the key(title in the hidden marker) and the title of the value(title in the jbs issue). If not, pr bot would add " ?? Title mismatch between PR and JBS." to the issue. This check makes sense for title issue, but not for additional issues because we only display title of jbs issues for additional issues. > > For example, if I have a pr whose title is "1: Test issue1", and then I use "/issue add 2" to associate another issue with this PR. Pr bot would add a hidden marker "" in a comment. > And I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test issue2 > " > in the pr body. > > If I update the title of TEST-2 to "Test newIssue2" in JBS. > > I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test newIssue2( ?? Title mismatch between PR and JBS.) > " > in the pr body because the jbs issue title is different from the issue title in the hidden marker. > > The only way to fix it is removing the issue by "/issue remove 2" and then add it again. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1647#issuecomment-2099462734 From zsong at openjdk.org Tue May 7 23:20:40 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 7 May 2024 23:20:40 GMT Subject: Integrated: 2253: No need to check title mismatch between PR and JBS for additional issues In-Reply-To: References: Message-ID: On Tue, 7 May 2024 19:03:19 GMT, Zhao Song wrote: > Users can use command /issue to associate more issues with a pr. When processing an /issue command, skara bot would add a hidden marker like this " -- >" in a comment. Later, in CheckRun, the pr bot would parse the hidden markers to get all additional issues and use them as keys in regularIssuesMap. The values of regularIssuesMap are jbs issues. Pr bot would check if the issue title matches between the title of the key(title in the hidden marker) and the title of the value(title in the jbs issue). If not, pr bot would add " ?? Title mismatch between PR and JBS." to the issue. This check makes sense for title issue, but not for additional issues because we only display title of jbs issues for additional issues. > > For example, if I have a pr whose title is "1: Test issue1", and then I use "/issue add 2" to associate another issue with this PR. Pr bot would add a hidden marker "" in a comment. > And I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test issue2 > " > in the pr body. > > If I update the title of TEST-2 to "Test newIssue2" in JBS. > > I would see > " > Issue > TEST-1: Test issue1 > TEST-2: Test newIssue2( ?? Title mismatch between PR and JBS.) > " > in the pr body because the jbs issue title is different from the issue title in the hidden marker. > > The only way to fix it is removing the issue by "/issue remove 2" and then add it again. This pull request has now been integrated. Changeset: 7ac15b02 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/7ac15b02aa0125bcd11a61d1d62080a206c91763 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 2253: No need to check title mismatch between PR and JBS for additional issues Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1647 From zsong at openjdk.org Thu May 9 18:34:39 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 18:34:39 GMT Subject: RFR: 2255: Keep additional issue marker updated Message-ID: Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker. To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS. ------------- Commit messages: - update - SKARA-2255 Changes: https://git.openjdk.org/skara/pull/1649/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1649&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2255 Stats: 60 lines in 5 files changed: 51 ins; 4 del; 5 mod Patch: https://git.openjdk.org/skara/pull/1649.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1649/head:pull/1649 PR: https://git.openjdk.org/skara/pull/1649 From zsong at openjdk.org Thu May 9 18:36:56 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 18:36:56 GMT Subject: RFR: 2255: Keep additional issue marker updated In-Reply-To: References: Message-ID: <_zTN0HtsayaxjOfJwpWfPz2HV3IfJtG_l1FcA38jGlQ=.8f2de90f-6d4f-4fb0-8115-948aa2e930e8@github.com> On Thu, 9 May 2024 18:09:54 GMT, Zhao Song wrote: > Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker. To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS. bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 769: > 767: } > 768: } > 769: if (!relaxedEquals(issueTrackerIssue.get().title(), issue.description())) { I reverted SKARA-2253 here. Since the issue marker will be updated automatically, the title in the hidden issue marker should always be equal with the title of issuetrackerIssue. If they are not equal, it means some issues happened, so we'd better add a warning here. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1649#discussion_r1595831834 From erikj at openjdk.org Thu May 9 18:56:24 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 9 May 2024 18:56:24 GMT Subject: RFR: 2255: Keep additional issue marker updated In-Reply-To: References: Message-ID: On Thu, 9 May 2024 18:09:54 GMT, Zhao Song wrote: > Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker. To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1649#pullrequestreview-2048612635 From zsong at openjdk.org Thu May 9 19:01:24 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 19:01:24 GMT Subject: RFR: 2255: Keep additional issue marker updated In-Reply-To: References: Message-ID: On Thu, 9 May 2024 18:09:54 GMT, Zhao Song wrote: > Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker. To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1649#issuecomment-2103243113 From zsong at openjdk.org Thu May 9 19:01:24 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 19:01:24 GMT Subject: Integrated: 2255: Keep additional issue marker updated In-Reply-To: References: Message-ID: On Thu, 9 May 2024 18:09:54 GMT, Zhao Song wrote: > Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker. To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS. This pull request has now been integrated. Changeset: 4e3d7e5b Author: Zhao Song URL: https://git.openjdk.org/skara/commit/4e3d7e5bb0c63008ea47d68854be64cfea577212 Stats: 60 lines in 5 files changed: 51 ins; 4 del; 5 mod 2255: Keep additional issue marker updated Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1649 From zsong at openjdk.org Thu May 9 21:20:39 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 21:20:39 GMT Subject: RFR: 2256: Return IssuesTitleIssue when either issuesWithTrailingPeriod or issuesWithLeadingLowerCaseLetter is not empty Message-ID: In SKARA-2170, I made a mistake, when checking if the issuestitle check fails, the bot only checks if issuesWithTrailingPeriod isn't empty. However, issuestitle check should also fail when issuesWithLeadingLowerCaseLetter is not empty. ------------- Commit messages: - SKARA-2256 Changes: https://git.openjdk.org/skara/pull/1650/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1650&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2256 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1650.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1650/head:pull/1650 PR: https://git.openjdk.org/skara/pull/1650 From erikj at openjdk.org Thu May 9 21:24:33 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 9 May 2024 21:24:33 GMT Subject: RFR: 2256: Return IssuesTitleIssue when either issuesWithTrailingPeriod or issuesWithLeadingLowerCaseLetter is not empty In-Reply-To: References: Message-ID: On Thu, 9 May 2024 21:15:16 GMT, Zhao Song wrote: > In SKARA-2170, I made a mistake, when checking if the issuestitle check fails, the bot only checks if issuesWithTrailingPeriod isn't empty. However, issuestitle check should also fail when issuesWithLeadingLowerCaseLetter is not empty. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1650#pullrequestreview-2048863602 From zsong at openjdk.org Thu May 9 21:27:53 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 21:27:53 GMT Subject: RFR: 2256: Return IssuesTitleIssue when either issuesWithTrailingPeriod or issuesWithLeadingLowerCaseLetter is not empty In-Reply-To: References: Message-ID: On Thu, 9 May 2024 21:15:16 GMT, Zhao Song wrote: > In SKARA-2170, I made a mistake, when checking if the issuestitle check fails, the bot only checks if issuesWithTrailingPeriod isn't empty. However, issuestitle check should also fail when issuesWithLeadingLowerCaseLetter is not empty. Thank you for the quick review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1650#issuecomment-2103443333 From zsong at openjdk.org Thu May 9 21:27:53 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 9 May 2024 21:27:53 GMT Subject: Integrated: 2256: Return IssuesTitleIssue when either issuesWithTrailingPeriod or issuesWithLeadingLowerCaseLetter is not empty In-Reply-To: References: Message-ID: <2xWztVrva_ES9PrXcJIgVGWchiDA0Zy1Ep-Bo-hMxzo=.58f18a4a-cc6b-4356-b827-77b34927c696@github.com> On Thu, 9 May 2024 21:15:16 GMT, Zhao Song wrote: > In SKARA-2170, I made a mistake, when checking if the issuestitle check fails, the bot only checks if issuesWithTrailingPeriod isn't empty. However, issuestitle check should also fail when issuesWithLeadingLowerCaseLetter is not empty. This pull request has now been integrated. Changeset: fd0c6a7d Author: Zhao Song URL: https://git.openjdk.org/skara/commit/fd0c6a7dfd4760ebaa3f078cfed997dff103c9fe Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 2256: Return IssuesTitleIssue when either issuesWithTrailingPeriod or issuesWithLeadingLowerCaseLetter is not empty Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1650 From zsong at openjdk.org Fri May 10 18:37:39 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 10 May 2024 18:37:39 GMT Subject: RFR: 2252: Backport command branch names not unique enough Message-ID: To avoid the name clash of backport branch in the bot's fork, we could add `targetBranchName` to the backport branch name. ------------- Commit messages: - SKARA-2252 Changes: https://git.openjdk.org/skara/pull/1651/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1651&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2252 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1651.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1651/head:pull/1651 PR: https://git.openjdk.org/skara/pull/1651 From erikj at openjdk.org Fri May 10 20:03:28 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Fri, 10 May 2024 20:03:28 GMT Subject: RFR: 2252: Backport command branch names not unique enough In-Reply-To: References: Message-ID: On Fri, 10 May 2024 18:33:03 GMT, Zhao Song wrote: > To avoid the name clash of backport branch in the bot's fork, we could add `targetBranchName` to the backport branch name. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1651#pullrequestreview-2050786268 From zsong at openjdk.org Fri May 10 20:32:29 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 10 May 2024 20:32:29 GMT Subject: RFR: 2252: Backport command branch names not unique enough In-Reply-To: References: Message-ID: On Fri, 10 May 2024 18:33:03 GMT, Zhao Song wrote: > To avoid the name clash of backport branch in the bot's fork, we could add `targetBranchName` to the backport branch name. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1651#issuecomment-2105234053 From zsong at openjdk.org Fri May 10 20:32:29 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 10 May 2024 20:32:29 GMT Subject: Integrated: 2252: Backport command branch names not unique enough In-Reply-To: References: Message-ID: On Fri, 10 May 2024 18:33:03 GMT, Zhao Song wrote: > To avoid the name clash of backport branch in the bot's fork, we could add `targetBranchName` to the backport branch name. This pull request has now been integrated. Changeset: d467fe37 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/d467fe373c92b37744a0c2c50537adb05d427e07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 2252: Backport command branch names not unique enough Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1651 From zsong at openjdk.org Tue May 28 21:35:27 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 21:35:27 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username Message-ID: Currently, Skara bot can't correctly handle HTTP status code 301 in rest requests. This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. ------------- Commit messages: - SKARA-2266 Changes: https://git.openjdk.org/skara/pull/1652/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1652&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2266 Stats: 17 lines in 2 files changed: 16 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1652.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1652/head:pull/1652 PR: https://git.openjdk.org/skara/pull/1652 From erikj at openjdk.org Tue May 28 22:38:37 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 28 May 2024 22:38:37 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username In-Reply-To: References: Message-ID: On Tue, 28 May 2024 21:31:08 GMT, Zhao Song wrote: > TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. > This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. network/src/main/java/org/openjdk/skara/network/RestRequest.java line 336: > 334: if (location.isPresent()) { > 335: request = request.uri(URI.create(location.get())); > 336: continue; I think we should increment the retryCount here to avoid the possibility of bad server behavior causing us to get stuck in a loop. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617960395 From zsong at openjdk.org Tue May 28 22:42:12 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 22:42:12 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username In-Reply-To: References: Message-ID: On Tue, 28 May 2024 22:36:11 GMT, Erik Joelsson wrote: >> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. >> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. > > network/src/main/java/org/openjdk/skara/network/RestRequest.java line 336: > >> 334: if (location.isPresent()) { >> 335: request = request.uri(URI.create(location.get())); >> 336: continue; > > I think we should increment the retryCount here to avoid the possibility of bad server behavior causing us to get stuck in a loop. It's a good point! ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617963557 From zsong at openjdk.org Tue May 28 22:48:36 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 22:48:36 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v2] In-Reply-To: References: Message-ID: > TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. > This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/skara/pull/1652/files - new: https://git.openjdk.org/skara/pull/1652/files/ac7cd148..170496ed Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1652&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1652&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1652.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1652/head:pull/1652 PR: https://git.openjdk.org/skara/pull/1652 From erikj at openjdk.org Tue May 28 23:00:57 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 28 May 2024 23:00:57 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v2] In-Reply-To: References: Message-ID: On Tue, 28 May 2024 22:48:36 GMT, Zhao Song wrote: >> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. >> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update network/src/main/java/org/openjdk/skara/network/RestRequest.java line 332: > 330: response = cache.send(authId, request, skipLimiter); > 331: // If the status code is 301(Moved Permanently), follow the redirect link > 332: if (response.statusCode() == 301) { I think we need to check the retryCount here like for the `401` case below, otherwise there is no break condition if the server keeps responding 301. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617974548 From zsong at openjdk.org Tue May 28 23:07:40 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 23:07:40 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v2] In-Reply-To: References: Message-ID: On Tue, 28 May 2024 22:58:35 GMT, Erik Joelsson wrote: >> Zhao Song has updated the pull request incrementally with one additional commit since the last revision: >> >> update > > network/src/main/java/org/openjdk/skara/network/RestRequest.java line 332: > >> 330: response = cache.send(authId, request, skipLimiter); >> 331: // If the status code is 301(Moved Permanently), follow the redirect link >> 332: if (response.statusCode() == 301) { > > I think we need to check the retryCount here like for the `401` case below, otherwise there is no break condition if the server keeps responding 301. My bad, will fix it ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617978181 From zsong at openjdk.org Tue May 28 23:14:43 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 23:14:43 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v3] In-Reply-To: References: Message-ID: > TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. > This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. Zhao Song has updated the pull request incrementally with two additional commits since the last revision: - update - update ------------- Changes: - all: https://git.openjdk.org/skara/pull/1652/files - new: https://git.openjdk.org/skara/pull/1652/files/170496ed..5c46a26a Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1652&range=02 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1652&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1652.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1652/head:pull/1652 PR: https://git.openjdk.org/skara/pull/1652 From erikj at openjdk.org Tue May 28 23:20:39 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 28 May 2024 23:20:39 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v3] In-Reply-To: References: Message-ID: On Tue, 28 May 2024 23:14:43 GMT, Zhao Song wrote: >> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. >> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. > > Zhao Song has updated the pull request incrementally with two additional commits since the last revision: > > - update > - update Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1652#pullrequestreview-2083988732 From zsong at openjdk.org Tue May 28 23:33:30 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 23:33:30 GMT Subject: RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v3] In-Reply-To: References: Message-ID: <7ZOTfZqCiZFpqIJmIfz5aX-0I0vEospNBwfmMCfHziY=.4754350e-77b7-4b09-87bc-5b795e47e9a6@github.com> On Tue, 28 May 2024 23:14:43 GMT, Zhao Song wrote: >> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. >> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. > > Zhao Song has updated the pull request incrementally with two additional commits since the last revision: > > - update > - update Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1652#issuecomment-2136264545 From zsong at openjdk.org Tue May 28 23:33:30 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 28 May 2024 23:33:30 GMT Subject: Integrated: 2266: TestInfoBot couldn't get checks after user changed their GitHub username In-Reply-To: References: Message-ID: On Tue, 28 May 2024 21:31:08 GMT, Zhao Song wrote: > TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. > This patch is trying to make skara bot follows the redirect link when it encounters 301 status code. This pull request has now been integrated. Changeset: 54ca2592 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/54ca25923a5604fd865e80df50dd0496abb6d633 Stats: 17 lines in 2 files changed: 15 ins; 0 del; 2 mod 2266: TestInfoBot couldn't get checks after user changed their GitHub username Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1652 From zsong at openjdk.org Fri May 31 19:12:39 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 31 May 2024 19:12:39 GMT Subject: RFR: 2272: Improve issuestitleCheck Message-ID: IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying. In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues. ------------- Commit messages: - SKARA-2272 Changes: https://git.openjdk.org/skara/pull/1653/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1653&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2272 Stats: 38 lines in 2 files changed: 34 ins; 0 del; 4 mod Patch: https://git.openjdk.org/skara/pull/1653.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1653/head:pull/1653 PR: https://git.openjdk.org/skara/pull/1653 From zsong at openjdk.org Fri May 31 19:12:40 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 31 May 2024 19:12:40 GMT Subject: RFR: 2272: Improve issuestitleCheck In-Reply-To: References: Message-ID: <8Xono1_QX3QIT3mCKFkz80rRuBC4k0SPZpypW8t7sQM=.0a142f21-98f1-4a27-b3f9-329d6a0ab561@github.com> On Fri, 31 May 2024 19:02:09 GMT, Zhao Song wrote: > IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying. > > In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues. jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 39: > 37: private final static List VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "..."); > 38: private final static List EXECUTABLE_NAMES = List.of("javac", "dpkg"); > 39: private final static Pattern FILE_OR_FUNCTION_PATTERN = Pattern.compile(".*[()/._].*"); Instead of writing regexs, I think maintaining some lists here would be easier to understand. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1622853131 From erikj at openjdk.org Fri May 31 20:07:27 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Fri, 31 May 2024 20:07:27 GMT Subject: RFR: 2272: Improve issuestitleCheck In-Reply-To: References: Message-ID: <1grzUYpQ_gvP2EpiYFNb7DnKMopa_0lQeyZPyO9NTek=.5e88a55f-6f9c-4dbf-87f5-35d52585299e@github.com> On Fri, 31 May 2024 19:02:09 GMT, Zhao Song wrote: > IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying. > > In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues. jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 38: > 36: private final Logger log = Logger.getLogger("org.openjdk.skara.jcheck.issuesTitle"); > 37: private final static List VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "..."); > 38: private final static List EXECUTABLE_NAMES = List.of("javac", "dpkg"); This list would potentially get very long. I'm not sure it's worth trying to maintain one. The other patterns seem ok to me. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1622903977 From zsong at openjdk.org Fri May 31 20:33:51 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 31 May 2024 20:33:51 GMT Subject: RFR: 2272: Improve issuestitleCheck In-Reply-To: <1grzUYpQ_gvP2EpiYFNb7DnKMopa_0lQeyZPyO9NTek=.5e88a55f-6f9c-4dbf-87f5-35d52585299e@github.com> References: <1grzUYpQ_gvP2EpiYFNb7DnKMopa_0lQeyZPyO9NTek=.5e88a55f-6f9c-4dbf-87f5-35d52585299e@github.com> Message-ID: On Fri, 31 May 2024 20:05:20 GMT, Erik Joelsson wrote: >> IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying. >> >> In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues. > > jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 38: > >> 36: private final Logger log = Logger.getLogger("org.openjdk.skara.jcheck.issuesTitle"); >> 37: private final static List VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "..."); >> 38: private final static List EXECUTABLE_NAMES = List.of("javac", "dpkg"); > > This list would potentially get very long. I'm not sure it's worth trying to maintain one. The other patterns seem ok to me. I was thinking we should ask if David Holmes has any thoughts about this list... ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1622925753 From zsong at openjdk.org Fri May 31 21:13:17 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 31 May 2024 21:13:17 GMT Subject: RFR: 2272: Improve issuestitleCheck [v2] In-Reply-To: References: Message-ID: > IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying. > > In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: add : in regex ------------- Changes: - all: https://git.openjdk.org/skara/pull/1653/files - new: https://git.openjdk.org/skara/pull/1653/files/d3a9bb3e..9b0dcc3b Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1653&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1653&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1653.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1653/head:pull/1653 PR: https://git.openjdk.org/skara/pull/1653 From erikj at openjdk.org Fri May 31 23:40:48 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Fri, 31 May 2024 23:40:48 GMT Subject: RFR: 2272: Improve issuestitleCheck [v2] In-Reply-To: References: <1grzUYpQ_gvP2EpiYFNb7DnKMopa_0lQeyZPyO9NTek=.5e88a55f-6f9c-4dbf-87f5-35d52585299e@github.com> Message-ID: On Fri, 31 May 2024 20:31:39 GMT, Zhao Song wrote: >> jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 38: >> >>> 36: private final Logger log = Logger.getLogger("org.openjdk.skara.jcheck.issuesTitle"); >>> 37: private final static List VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "..."); >>> 38: private final static List EXECUTABLE_NAMES = List.of("javac", "dpkg"); >> >> This list would potentially get very long. I'm not sure it's worth trying to maintain one. The other patterns seem ok to me. > > I was thinking we should ask if David Holmes has any thoughts about this list... No I think it should just be removed. Otherwise we will end up having to list every executable in the JDK as well as basically every build tool used when building it, and even so, that would be a very JDK project specific list of executables. Several of those would also overlap with words that we would want to flag, e.g. "make", "java". ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1623038258