Integrated: 2170: Warn on trailing period in PR titles

Zhao Song zsong at openjdk.org
Tue May 7 16:21:45 UTC 2024


On Mon, 15 Apr 2024 22:45:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period or leading lowercase letter. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods or leading lowercase letter are valid.
> 
> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests.  Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly.

This pull request has now been integrated.

Changeset: 2edf2280
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/2edf2280cbc800a7e578e134d68fe9b33f8e1bd7
Stats:     390 lines in 11 files changed: 283 ins; 0 del; 107 mod

2170: Warn on trailing period in PR titles
2248: Warn on leading lowercase letter in PR titles

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1638


More information about the skara-dev mailing list