Integrated: 2253: No need to check title mismatch between PR and JBS for additional issues

[Zhao Song]

On Tue, 7 May 2024 19:03:19 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Users can use command /issue to associate more issues with a pr. When processing an /issue command, skara bot would add a hidden marker like this "<! -- solves: <issueId> <issueTitle> -- >" in a comment. Later, in CheckRun, the pr bot would parse the hidden markers to get all additional issues and use them as keys in regularIssuesMap. The values of regularIssuesMap are jbs issues. Pr bot would check if the issue title matches between the title of the key(title in the hidden marker) and the title of the value(title in the jbs issue). If not, pr bot would add " ⚠️ Title mismatch between PR and JBS." to the issue. This check makes sense for title issue, but not for additional issues because we only display title of jbs issues for additional issues.
> 
> For example, if I have a pr whose title is "1: Test issue1", and then I use "/issue add 2" to associate another issue with this PR. Pr bot would add a hidden marker "<! -- solves: 2 Test issue2 -- >" in a comment.
> And I would see
> "
> Issue
>  TEST-1: Test issue1
>  TEST-2: Test issue2
> "
> in the pr body.
> 
> If I update the title of TEST-2 to "Test newIssue2" in JBS.
> 
> I would see
> "
> Issue
>  TEST-1: Test issue1
>  TEST-2: Test newIssue2( ⚠️ Title mismatch between PR and JBS.)
> "
> in the pr body because the jbs issue title is different from the issue title in the hidden marker.
> 
> The only way to fix it is removing the issue by "/issue remove 2" and then add it again.

This pull request has now been integrated.

Changeset: 7ac15b02
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/7ac15b02aa0125bcd11a61d1d62080a206c91763
Stats:     4 lines in 1 file changed: 3 ins; 0 del; 1 mod

2253: No need to check title mismatch between PR and JBS for additional issues

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1647