RFR: 2255: Keep additional issue marker updated

Zhao Song zsong at openjdk.org
Thu May 9 18:36:56 UTC 2024


On Thu, 9 May 2024 18:09:54 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, additional issue marker is not updated automatically, it means if user changed the title of an additional issue in JBS, the user will need to issue `/issue` command again to update the additional issue. However, for additional issues, users are not aware that skara bot would store the issue title in a hidden marker.  To avoid confusion, we'd better let skara bot update the hidden marker automatically when user changes the issue title in JBS.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 769:

> 767:                             }
> 768:                         }
> 769:                         if (!relaxedEquals(issueTrackerIssue.get().title(), issue.description())) {

I reverted SKARA-2253 here. Since the issue marker will be updated automatically, the title in the hidden issue marker should always be equal with the title of issuetrackerIssue. If they are not equal, it means some issues happened, so we'd better add a warning here.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1649#discussion_r1595831834


More information about the skara-dev mailing list