RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username

[Zhao Song]

On Tue, 28 May 2024 22:36:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. 
>> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code.
>
> network/src/main/java/org/openjdk/skara/network/RestRequest.java line 336:
> 
>> 334:                     if (location.isPresent()) {
>> 335:                         request = request.uri(URI.create(location.get()));
>> 336:                         continue;
> 
> I think we should increment the retryCount here to avoid the possibility of bad server behavior causing us to get stuck in a loop.

It's a good point!

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617963557