RFR: 2266: TestInfoBot couldn't get checks after user changed their GitHub username [v2]

[Erik Joelsson]

On Tue, 28 May 2024 22:48:36 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> TestInfoBot couldn't get checks after user changed their GitHub username, the root cause is that Skara bot can't correctly handle HTTP status code 301 in rest requests. 
>> This patch is trying to make skara bot follows the redirect link when it encounters 301 status code.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

network/src/main/java/org/openjdk/skara/network/RestRequest.java line 332:

> 330:                 response = cache.send(authId, request, skipLimiter);
> 331:                 // If the status code is 301(Moved Permanently), follow the redirect link
> 332:                 if (response.statusCode() == 301) {

I think we need to check the retryCount here like for the `401` case below, otherwise there is no break condition if the server keeps responding 301.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1652#discussion_r1617974548