RFR: 2272: Improve issuestitleCheck

Zhao Song zsong at openjdk.org
Fri May 31 19:12:40 UTC 2024


On Fri, 31 May 2024 19:02:09 GMT, Zhao Song <zsong at openjdk.org> wrote:

> IssuestitleCheck was enabled in jdk recently, but this seems triggers too many false positive warnings and makes people feel annoying.
> 
> In this patch, I am trying to make the issuestitle check more tolerant. For some known cases, issuestitle check wouldn't generate issues.

jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesTitleCheck.java line 39:

> 37:     private final static List<String> VALID_WORD_WITH_TRAILING_PERIOD = List.of("et al.", "etc.", "...");
> 38:     private final static List<String> EXECUTABLE_NAMES = List.of("javac", "dpkg");
> 39:     private final static Pattern FILE_OR_FUNCTION_PATTERN = Pattern.compile(".*[()/._].*");

Instead of writing regexs, I think maintaining some lists here would be easier to understand.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1653#discussion_r1622853131


More information about the skara-dev mailing list