RFR: 2400: Avoid overwriting mbox archive [v2]

Erik Joelsson erikj at openjdk.org
Tue Nov 19 00:04:58 UTC 2024


On Mon, 18 Nov 2024 23:48:26 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Sometimes, the ArchiveWorkItem fails to retrieve the current contents of an mbox file while processing a PR. When this happens, it will resend all emails. Erik pointed out that in GitLab, creating a new file uses a POST request, while updating an existing file uses PUT. Similarly, GitHub requires the current "SHA" to update a file.
>> 
>> The ArchiveWorkItem can determine whether it found existing content in the mbox archive and choose the right method accordingly. If it incorrectly fails to retrieve the existing content from GitLab or GitHub, it will attempt to create a new file. This attempt should fail, triggering a retry of the WorkItem, which would ideally succeed in retrieving the existing content.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1696#pullrequestreview-2444023831


More information about the skara-dev mailing list