Integrated: 2400: Avoid overwriting mbox archive
Zhao Song
zsong at openjdk.org
Tue Nov 19 18:29:17 UTC 2024
On Mon, 18 Nov 2024 21:44:55 GMT, Zhao Song <zsong at openjdk.org> wrote:
> Sometimes, the ArchiveWorkItem fails to retrieve the current contents of an mbox file while processing a PR. When this happens, it will resend all emails. Erik pointed out that in GitLab, creating a new file uses a POST request, while updating an existing file uses PUT. Similarly, GitHub requires the current "SHA" to update a file.
>
> The ArchiveWorkItem can determine whether it found existing content in the mbox archive and choose the right method accordingly. If it incorrectly fails to retrieve the existing content from GitLab or GitHub, it will attempt to create a new file. This attempt should fail, triggering a retry of the WorkItem, which would ideally succeed in retrieving the existing content.
This pull request has now been integrated.
Changeset: 4666739a
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/4666739a6cc42616b440ceeafb67c9e992cb1483
Stats: 57 lines in 9 files changed: 21 ins; 2 del; 34 mod
2400: Avoid overwriting mbox archive
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1696
More information about the skara-dev
mailing list