RFR: 2410: Introduce process killing finally block in GitCommits

[Pavel Rappo]

On Tue, 19 Nov 2024 18:39:41 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Recently, I found that for pr-external container, in GitCommits, the exit of the git process could time out and then the process will be stuck in sleeping state and eat memory. With Pavel's suggestion, I think we should introduce the process killing finally block.

vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommits.java line 170:

> 168:             throw new IOException("'" + String.join(" ", command) + "' was interrupted", e);
> 169:         } finally {
> 170:             if (p.isAlive()) {

For the record, this might be insufficient because `GitCommits` might have created multiple processes and this destroys only one of them.

In general, Skara needs better tools to deal with processes.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1697#discussion_r1849143881