Integrated: 2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown

Zhao Song zsong at openjdk.org
Fri Nov 22 18:27:47 UTC 2024


On Thu, 21 Nov 2024 18:16:45 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As Pavel pointed out in the pull request of [SKARA-2410](https://bugs.openjdk.org/browse/SKARA-2410)(https://github.com/openjdk/skara/pull/1697), with current implementation , GitCommits::close may have created multiple processes and only destroy one of them.
> 
> As Erik and Pavel suggested, we should make sure close() is called on each process.

This pull request has now been integrated.

Changeset: a42517c6
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/a42517c63e3a7489629a81aafd96e0cfe290ea9a
Stats:     19 lines in 1 file changed: 18 ins; 0 del; 1 mod

2415: Update GitCommits::close to make sure it terminates all processes when an exception is thrown

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1699


More information about the skara-dev mailing list