From zsong at openjdk.org Mon Oct 7 20:11:30 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 7 Oct 2024 20:11:30 GMT Subject: RFR: 2363: When jcheck result is too big, it can't be published to Github Message-ID: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> Sometimes, a pull request contains too many whitespace errors and it will generate a large jcheck result. Therefore, when the bot is trying to post it to GitHub, it will fail and keep retrying. This patch is trying to limit the size of jcheck error message. ------------- Commit messages: - SKARA-2363 Changes: https://git.openjdk.org/skara/pull/1688/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1688&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2363 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/skara/pull/1688.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1688/head:pull/1688 PR: https://git.openjdk.org/skara/pull/1688 From erikj at openjdk.org Mon Oct 7 20:47:32 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 7 Oct 2024 20:47:32 GMT Subject: RFR: 2363: When jcheck result is too big, it can't be published to Github In-Reply-To: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> References: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> Message-ID: On Mon, 7 Oct 2024 20:07:13 GMT, Zhao Song wrote: > Sometimes, a pull request contains too many whitespace errors and it will generate a large jcheck result. Therefore, when the bot is trying to post it to GitHub, it will fail and keep retrying. > > This patch is trying to limit the size of jcheck error message. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1688#pullrequestreview-2352902635 From zsong at openjdk.org Mon Oct 7 20:52:59 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 7 Oct 2024 20:52:59 GMT Subject: RFR: 2363: When jcheck result is too big, it can't be published to Github In-Reply-To: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> References: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> Message-ID: On Mon, 7 Oct 2024 20:07:13 GMT, Zhao Song wrote: > Sometimes, a pull request contains too many whitespace errors and it will generate a large jcheck result. Therefore, when the bot is trying to post it to GitHub, it will fail and keep retrying. > > This patch is trying to limit the size of jcheck error message. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1688#issuecomment-2397869685 From zsong at openjdk.org Mon Oct 7 20:52:59 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 7 Oct 2024 20:52:59 GMT Subject: Integrated: 2363: When jcheck result is too big, it can't be published to Github In-Reply-To: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> References: <4CbZ12F8YXfLJhybpKItS551cDViD6rYubdk-mFFNHQ=.8d3d2ef4-0a98-49cc-80ac-707fad7e6b5f@github.com> Message-ID: On Mon, 7 Oct 2024 20:07:13 GMT, Zhao Song wrote: > Sometimes, a pull request contains too many whitespace errors and it will generate a large jcheck result. Therefore, when the bot is trying to post it to GitHub, it will fail and keep retrying. > > This patch is trying to limit the size of jcheck error message. This pull request has now been integrated. Changeset: e40bda95 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/e40bda95c4c7010a69c69b4a5cb0260c007227a1 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod 2363: When jcheck result is too big, it can't be published to Github Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1688 From zsong at openjdk.org Tue Oct 8 21:24:17 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 8 Oct 2024 21:24:17 GMT Subject: RFR: 2386: PullRequestBotFactory creates too many IssueBots Message-ID: Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class. This patch is trying to fix this issue as Erik suggested: 1. Caching the issueProject instances in a map. 2. Avoiding using IssueProject as a key in maps. ------------- Commit messages: - SKARA-2386 Changes: https://git.openjdk.org/skara/pull/1689/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1689&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2386 Stats: 22 lines in 1 file changed: 6 ins; 0 del; 16 mod Patch: https://git.openjdk.org/skara/pull/1689.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1689/head:pull/1689 PR: https://git.openjdk.org/skara/pull/1689 From erikj at openjdk.org Tue Oct 8 23:21:15 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 8 Oct 2024 23:21:15 GMT Subject: RFR: 2386: PullRequestBotFactory creates too many IssueBots In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 21:19:30 GMT, Zhao Song wrote: > Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class. > > This patch is trying to fix this issue as Erik suggested: > 1. Caching the issueProject instances in a map. > 2. Avoiding using IssueProject as a key in maps. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1689#pullrequestreview-2355694001 From zsong at openjdk.org Tue Oct 8 23:27:41 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 8 Oct 2024 23:27:41 GMT Subject: RFR: 2386: PullRequestBotFactory creates too many IssueBots In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 21:19:30 GMT, Zhao Song wrote: > Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class. > > This patch is trying to fix this issue as Erik suggested: > 1. Caching the issueProject instances in a map. > 2. Avoiding using IssueProject as a key in maps. Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1689#issuecomment-2400982784 From zsong at openjdk.org Tue Oct 8 23:27:41 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 8 Oct 2024 23:27:41 GMT Subject: Integrated: 2386: PullRequestBotFactory creates too many IssueBots In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 21:19:30 GMT, Zhao Song wrote: > Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class. > > This patch is trying to fix this issue as Erik suggested: > 1. Caching the issueProject instances in a map. > 2. Avoiding using IssueProject as a key in maps. This pull request has now been integrated. Changeset: cf23f68f Author: Zhao Song URL: https://git.openjdk.org/skara/commit/cf23f68fbf97c7a58d5d8ce1ba8072cc381d7f65 Stats: 22 lines in 1 file changed: 6 ins; 0 del; 16 mod 2386: PullRequestBotFactory creates too many IssueBots Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1689 From zsong at openjdk.org Wed Oct 9 17:50:14 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 9 Oct 2024 17:50:14 GMT Subject: RFR: 2387: Revert SKARA-2386 and cache issueProject in JiraHost Message-ID: In [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386), we are using the issueProject name as the key of different maps in PullRequestBotFactory. But they are not unified. For issueProjectMap, the key is the full name of the issue project like "bugs/JDK". For other maps, the key is only the project name like "JDK". This will make the factory not be able to generate IssueBot correctly. Currently, I think maybe it's better to revert [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386) and cache the issueProject in JiraHost to fix the problem. ------------- Commit messages: - update - add comment - Revert "2386: PullRequestBotFactory creates too many IssueBots" - Merge branch 'master' into test2387 - 2387 Changes: https://git.openjdk.org/skara/pull/1690/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1690&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2387 Stats: 28 lines in 3 files changed: 5 ins; 6 del; 17 mod Patch: https://git.openjdk.org/skara/pull/1690.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1690/head:pull/1690 PR: https://git.openjdk.org/skara/pull/1690 From erikj at openjdk.org Wed Oct 9 18:05:40 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 9 Oct 2024 18:05:40 GMT Subject: RFR: 2387: Revert SKARA-2386 and cache issueProject in JiraHost In-Reply-To: References: Message-ID: On Wed, 9 Oct 2024 17:45:13 GMT, Zhao Song wrote: > In [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386), we are using the issueProject name as the key of different maps in PullRequestBotFactory. But they are not unified. > > For issueProjectMap, the key is the full name of the issue project like "bugs/JDK". For other maps, the key is only the project name like "JDK". > > This will make the factory not be able to generate IssueBot correctly. > > Currently, I think maybe it's better to revert [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386) and cache the issueProject in JiraHost to fix the problem. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1690#pullrequestreview-2357841865 From zsong at openjdk.org Wed Oct 9 18:08:23 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 9 Oct 2024 18:08:23 GMT Subject: RFR: 2387: Revert SKARA-2386 and cache issueProject in JiraHost In-Reply-To: References: Message-ID: On Wed, 9 Oct 2024 17:45:13 GMT, Zhao Song wrote: > In [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386), we are using the issueProject name as the key of different maps in PullRequestBotFactory. But they are not unified. > > For issueProjectMap, the key is the full name of the issue project like "bugs/JDK". For other maps, the key is only the project name like "JDK". > > This will make the factory not be able to generate IssueBot correctly. > > Currently, I think maybe it's better to revert [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386) and cache the issueProject in JiraHost to fix the problem. Thank you for the quick review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1690#issuecomment-2402963441 From zsong at openjdk.org Wed Oct 9 18:08:23 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 9 Oct 2024 18:08:23 GMT Subject: Integrated: 2387: Revert SKARA-2386 and cache issueProject in JiraHost In-Reply-To: References: Message-ID: On Wed, 9 Oct 2024 17:45:13 GMT, Zhao Song wrote: > In [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386), we are using the issueProject name as the key of different maps in PullRequestBotFactory. But they are not unified. > > For issueProjectMap, the key is the full name of the issue project like "bugs/JDK". For other maps, the key is only the project name like "JDK". > > This will make the factory not be able to generate IssueBot correctly. > > Currently, I think maybe it's better to revert [SKARA-2386](https://bugs.openjdk.org/browse/SKARA-2386) and cache the issueProject in JiraHost to fix the problem. This pull request has now been integrated. Changeset: 86977587 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/869775870d239337cb4fbc2cf10a6c0a0a07eaae Stats: 28 lines in 3 files changed: 5 ins; 6 del; 17 mod 2387: Revert SKARA-2386 and cache issueProject in JiraHost Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1690 From zsong at openjdk.org Wed Oct 16 22:05:41 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 16 Oct 2024 22:05:41 GMT Subject: RFR: 2391: Update .github/workflows/ci.yml Message-ID: Today I received an email from Github and in the email, GitHub says they are going to remove macOS 12 runner image soon. We should update our configuration since we are using macOS 12 runner right now. ------------- Commit messages: - SKARA-2391 Changes: https://git.openjdk.org/skara/pull/1691/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1691&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2391 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1691.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1691/head:pull/1691 PR: https://git.openjdk.org/skara/pull/1691 From erikj at openjdk.org Wed Oct 16 22:50:05 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 16 Oct 2024 22:50:05 GMT Subject: RFR: 2391: Update .github/workflows/ci.yml In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 22:01:27 GMT, Zhao Song wrote: > Today I received an email from Github and in the email, GitHub says they are going to remove macOS 12 runner image soon. > We should update our configuration since we are using macOS 12 runner right now. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1691#pullrequestreview-2373814764 From zsong at openjdk.org Wed Oct 16 22:54:44 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 16 Oct 2024 22:54:44 GMT Subject: RFR: 2391: Update .github/workflows/ci.yml In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 22:01:27 GMT, Zhao Song wrote: > Today I received an email from Github and in the email, GitHub says they are going to remove macOS 12 runner image soon. > We should update our configuration since we are using macOS 12 runner right now. Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1691#issuecomment-2418101065 From zsong at openjdk.org Wed Oct 16 22:54:44 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 16 Oct 2024 22:54:44 GMT Subject: Integrated: 2391: Update .github/workflows/ci.yml In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 22:01:27 GMT, Zhao Song wrote: > Today I received an email from Github and in the email, GitHub says they are going to remove macOS 12 runner image soon. > We should update our configuration since we are using macOS 12 runner right now. This pull request has now been integrated. Changeset: 98261e6e Author: Zhao Song URL: https://git.openjdk.org/skara/commit/98261e6efe578994823ff006b608da66350e8791 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 2391: Update .github/workflows/ci.yml Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1691 From zsong at openjdk.org Mon Oct 21 17:35:36 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 21 Oct 2024 17:35:36 GMT Subject: RFR: 2395: Make it configurable to disable the contributor check for the /backport command Message-ID: In a discussion with Erik offline, he pointed out that the /backport command is different from all other commit commands. Instead of affecting the current repository, it only reads information from it and creates a branch in a fork of another repository. On GitHub, since anyone can comment on commits, it makes sense to have access control. However, in GitLab, where only authorized engineers can access the relevant repositories, we can safely disable the contributor check. In summary, it makes sense to make it configurable to disable the contributor check for the /backport command. ------------- Commit messages: - SKARA-2395 Changes: https://git.openjdk.org/skara/pull/1692/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1692&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2395 Stats: 23 lines in 4 files changed: 19 ins; 0 del; 4 mod Patch: https://git.openjdk.org/skara/pull/1692.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1692/head:pull/1692 PR: https://git.openjdk.org/skara/pull/1692 From erikj at openjdk.org Mon Oct 21 18:26:06 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 21 Oct 2024 18:26:06 GMT Subject: RFR: 2395: Make it configurable to disable the contributor check for the /backport command In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 17:14:53 GMT, Zhao Song wrote: > In a discussion with Erik offline, he pointed out that the /backport command is different from all other commit commands. Instead of affecting the current repository, it only reads information from it and creates a branch in a fork of another repository. On GitHub, since anyone can comment on commits, it makes sense to have access control. However, in GitLab, where only authorized engineers can access the relevant repositories, we can safely disable the contributor check. In summary, it makes sense to make it configurable to disable the contributor check for the /backport command. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1692#pullrequestreview-2383009330 From zsong at openjdk.org Mon Oct 21 19:58:16 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 21 Oct 2024 19:58:16 GMT Subject: RFR: 2395: Make it configurable to disable the contributor check for the /backport command In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 17:14:53 GMT, Zhao Song wrote: > In a discussion with Erik offline, he pointed out that the /backport command is different from all other commit commands. Instead of affecting the current repository, it only reads information from it and creates a branch in a fork of another repository. On GitHub, since anyone can comment on commits, it makes sense to have access control. However, in GitLab, where only authorized engineers can access the relevant repositories, we can safely disable the contributor check. In summary, it makes sense to make it configurable to disable the contributor check for the /backport command. Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1692#issuecomment-2427596995 From zsong at openjdk.org Mon Oct 21 19:58:16 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 21 Oct 2024 19:58:16 GMT Subject: Integrated: 2395: Make it configurable to disable the contributor check for the /backport command In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 17:14:53 GMT, Zhao Song wrote: > In a discussion with Erik offline, he pointed out that the /backport command is different from all other commit commands. Instead of affecting the current repository, it only reads information from it and creates a branch in a fork of another repository. On GitHub, since anyone can comment on commits, it makes sense to have access control. However, in GitLab, where only authorized engineers can access the relevant repositories, we can safely disable the contributor check. In summary, it makes sense to make it configurable to disable the contributor check for the /backport command. This pull request has now been integrated. Changeset: 6da14cf5 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/6da14cf5d2843aaaec488fd1bb7af91730a9679b Stats: 23 lines in 4 files changed: 19 ins; 0 del; 4 mod 2395: Make it configurable to disable the contributor check for the /backport command Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1692 From zsong at openjdk.org Tue Oct 22 20:32:04 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 22 Oct 2024 20:32:04 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list Message-ID: This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. ------------- Commit messages: - SKARA-2300 Changes: https://git.openjdk.org/skara/pull/1693/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1693&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2300 Stats: 22 lines in 2 files changed: 19 ins; 0 del; 3 mod Patch: https://git.openjdk.org/skara/pull/1693.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1693/head:pull/1693 PR: https://git.openjdk.org/skara/pull/1693 From zsong at openjdk.org Tue Oct 22 22:31:46 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 22 Oct 2024 22:31:46 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: > This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: rename ------------- Changes: - all: https://git.openjdk.org/skara/pull/1693/files - new: https://git.openjdk.org/skara/pull/1693/files/a2a150cc..40eec231 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1693&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1693&range=00-01 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/skara/pull/1693.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1693/head:pull/1693 PR: https://git.openjdk.org/skara/pull/1693 From iris at openjdk.org Tue Oct 22 22:49:21 2024 From: iris at openjdk.org (Iris Clark) Date: Tue, 22 Oct 2024 22:49:21 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song wrote: >> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > rename bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java line 216: > 214: // Check that it has been approved > 215: assertTrue(authorPr.store().body().contains("Reviewers")); > 216: assertTrue(authorPr.store().body().contains("Reviewers without OpenJDK IDs")); I like how the new title relates to the old while clearly indicating the difference between the two lists. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1693#discussion_r1811531673 From prappo at openjdk.org Wed Oct 23 08:56:22 2024 From: prappo at openjdk.org (Pavel Rappo) Date: Wed, 23 Oct 2024 08:56:22 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song wrote: >> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > rename Marked as reviewed by prappo (Committer). ------------- PR Review: https://git.openjdk.org/skara/pull/1693#pullrequestreview-2387821302 From kcr at openjdk.org Wed Oct 23 12:11:26 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 23 Oct 2024 12:11:26 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song wrote: >> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > rename This looks good and will be more clear. Thank you. ------------- Marked as reviewed by kcr (Reviewer). PR Review: https://git.openjdk.org/skara/pull/1693#pullrequestreview-2388411376 From erikj at openjdk.org Wed Oct 23 12:49:40 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 23 Oct 2024 12:49:40 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song wrote: >> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > rename Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1693#pullrequestreview-2388556720 From zsong at openjdk.org Wed Oct 23 21:25:36 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 23 Oct 2024 21:25:36 GMT Subject: RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2] In-Reply-To: References: Message-ID: <59EvQms3chQA1cOxeHRfkMVT8lJn9srtk0TDyQXWv84=.d3c5ba1b-fa17-4f93-a6d0-fa231bc41ddc@github.com> On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song wrote: >> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > rename Thank you all for reviews! ------------- PR Comment: https://git.openjdk.org/skara/pull/1693#issuecomment-2433489745 From zsong at openjdk.org Wed Oct 23 21:25:36 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 23 Oct 2024 21:25:36 GMT Subject: Integrated: 2300: Do not list non-OpenJDK reviewers in Reviewers list In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 20:15:07 GMT, Zhao Song wrote: > This PR is trying to make skara bot list non-recognized user in a separate section in the PR body. This pull request has now been integrated. Changeset: 6e4b2b81 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/6e4b2b8125e814b8d4d9bd8f85f9e4a12c22e4f9 Stats: 22 lines in 2 files changed: 19 ins; 0 del; 3 mod 2300: Do not list non-OpenJDK reviewers in Reviewers list Reviewed-by: prappo, kcr, erikj ------------- PR: https://git.openjdk.org/skara/pull/1693 From zsong at openjdk.org Wed Oct 23 22:16:45 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 23 Oct 2024 22:16:45 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" Message-ID: Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. ------------- Commit messages: - SKARA-2397 Changes: https://git.openjdk.org/skara/pull/1694/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1694&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2397 Stats: 10 lines in 4 files changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.org/skara/pull/1694.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1694/head:pull/1694 PR: https://git.openjdk.org/skara/pull/1694 From erikj at openjdk.org Wed Oct 23 23:19:29 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 23 Oct 2024 23:19:29 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" In-Reply-To: References: Message-ID: On Wed, 23 Oct 2024 21:48:05 GMT, Zhao Song wrote: > Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. > > This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1694#pullrequestreview-2390840743 From erikj at openjdk.org Thu Oct 24 18:10:44 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 24 Oct 2024 18:10:44 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" In-Reply-To: References: Message-ID: On Wed, 23 Oct 2024 21:48:05 GMT, Zhao Song wrote: > Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. > > This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. Hold off on integrating, I think I found another issue. ------------- Changes requested by erikj (Lead). PR Review: https://git.openjdk.org/skara/pull/1694#pullrequestreview-2393402197 From erikj at openjdk.org Thu Oct 24 18:19:10 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 24 Oct 2024 18:19:10 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" In-Reply-To: References: Message-ID: On Wed, 23 Oct 2024 21:48:05 GMT, Zhao Song wrote: > Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. > > This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. I think we need to check for altfixversion independent of if requestedFixVersion has a value or not. That would make this even more robust. ------------- PR Comment: https://git.openjdk.org/skara/pull/1694#issuecomment-2436054064 From zsong at openjdk.org Thu Oct 24 21:00:32 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 24 Oct 2024 21:00:32 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" [v2] In-Reply-To: References: Message-ID: > Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. > > This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/skara/pull/1694/files - new: https://git.openjdk.org/skara/pull/1694/files/513ee404..e669d0c0 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1694&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1694&range=00-01 Stats: 38 lines in 1 file changed: 4 ins; 6 del; 28 mod Patch: https://git.openjdk.org/skara/pull/1694.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1694/head:pull/1694 PR: https://git.openjdk.org/skara/pull/1694 From erikj at openjdk.org Mon Oct 28 23:01:10 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 28 Oct 2024 23:01:10 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" [v2] In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 21:00:32 GMT, Zhao Song wrote: >> Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. >> >> This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1694#pullrequestreview-2400404403 From erikj at openjdk.org Mon Oct 28 23:06:14 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 28 Oct 2024 23:06:14 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR [v2] In-Reply-To: References: Message-ID: On Mon, 30 Sep 2024 20:19:35 GMT, Zhao Song wrote: >> PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1687#pullrequestreview-2400408818 From zsong at openjdk.org Tue Oct 29 16:30:58 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 29 Oct 2024 16:30:58 GMT Subject: RFR: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" [v2] In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 21:00:32 GMT, Zhao Song wrote: >> Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. >> >> This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1694#issuecomment-2444776745 From zsong at openjdk.org Tue Oct 29 16:30:58 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 29 Oct 2024 16:30:58 GMT Subject: Integrated: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" In-Reply-To: References: Message-ID: On Wed, 23 Oct 2024 21:48:05 GMT, Zhao Song wrote: > Currently, the Skara bot doesn't recognize "Delivered" as a valid resolution for resolved issues. As a result, when the bot finds an issue in a Resolved or Closed state with "Delivered" resolution, it will change the resolution to "Fixed." However, it shouldn't. > > This patch is trying to make the bot recognize "Delivered" as a valid resolution for resolved issues, preventing unnecessary changes. This pull request has now been integrated. Changeset: c7e1c2fd Author: Zhao Song URL: https://git.openjdk.org/skara/commit/c7e1c2fd2e8bad37721eac450c0869f2242d0662 Stats: 48 lines in 4 files changed: 11 ins; 6 del; 31 mod 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed" Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1694 From zsong at openjdk.org Tue Oct 29 16:31:13 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 29 Oct 2024 16:31:13 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR [v2] In-Reply-To: References: Message-ID: On Mon, 30 Sep 2024 20:19:35 GMT, Zhao Song wrote: >> PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1687#issuecomment-2444777394 From zsong at openjdk.org Tue Oct 29 16:31:13 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 29 Oct 2024 16:31:13 GMT Subject: Integrated: 2328: Ignore bot user's comment when determining the latest action time of a PR In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 17:48:10 GMT, Zhao Song wrote: > PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. This pull request has now been integrated. Changeset: e156edb5 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/e156edb566f68185eae16d9390ba5cfd2da2a359 Stats: 51 lines in 4 files changed: 32 ins; 0 del; 19 mod 2328: Ignore bot user's comment when determining the latest action time of a PR Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1687 From ihse at openjdk.org Wed Oct 30 11:45:10 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Wed, 30 Oct 2024 11:45:10 GMT Subject: RFR: 2401: Link to Webrev should be part of the Reviewing section Message-ID: When we added the link to the webrev comment in the PR body, for some reason it got its own header `### Webrev`. But Webrevs are just another way of reviewing, so it should be put under the `### Reviewing` header. That is, the reviewing html code should look something like this: ...
Using diff file Download this PR as a diff file: \ [https://git.openjdk.org/jdk/pull/XXX.diff</a](https://git.openjdk.org/jdk/pull/XXX.diff%3C/a)>
Using Webrev [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/XXX#issuecomment-YYY)
------------- Commit messages: - 2401: Link to Webrev should be part of the Reviewing section Changes: https://git.openjdk.org/skara/pull/1695/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1695&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2401 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1695.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1695/head:pull/1695 PR: https://git.openjdk.org/skara/pull/1695 From erikj at openjdk.org Wed Oct 30 12:43:58 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 30 Oct 2024 12:43:58 GMT Subject: RFR: 2401: Link to Webrev should be part of the Reviewing section In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 11:40:51 GMT, Magnus Ihse Bursie wrote: > When we added the link to the webrev comment in the PR body, for some reason it got its own header `### Webrev`. But Webrevs are just another way of reviewing, so it should be put under the `### Reviewing` header. > > That is, the reviewing html code should look something like this: > > ... >
Using diff file > > Download this PR as a diff file: \ > [https://git.openjdk.org/jdk/pull/XXX.diff</a](https://git.openjdk.org/jdk/pull/XXX.diff%3C/a)> > >
>
Using Webrev > > [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/XXX#issuecomment-YYY) > >
Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1695#pullrequestreview-2404742135 From ihse at openjdk.org Wed Oct 30 12:52:11 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Wed, 30 Oct 2024 12:52:11 GMT Subject: Integrated: 2401: Link to Webrev should be part of the Reviewing section In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 11:40:51 GMT, Magnus Ihse Bursie wrote: > When we added the link to the webrev comment in the PR body, for some reason it got its own header `### Webrev`. But Webrevs are just another way of reviewing, so it should be put under the `### Reviewing` header. > > That is, the reviewing html code should look something like this: > > ... >
Using diff file > > Download this PR as a diff file: \ > [https://git.openjdk.org/jdk/pull/XXX.diff</a](https://git.openjdk.org/jdk/pull/XXX.diff%3C/a)> > >
>
Using Webrev > > [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/XXX#issuecomment-YYY) > >
This pull request has now been integrated. Changeset: 18683e6b Author: Magnus Ihse Bursie URL: https://git.openjdk.org/skara/commit/18683e6bd6088704bef5587c7c2eeb648b06d743 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 2401: Link to Webrev should be part of the Reviewing section Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1695