RFR: 2386: PullRequestBotFactory creates too many IssueBots
Erik Joelsson
erikj at openjdk.org
Tue Oct 8 23:21:15 UTC 2024
On Tue, 8 Oct 2024 21:19:30 GMT, Zhao Song <zsong at openjdk.org> wrote:
> Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class.
>
> This patch is trying to fix this issue as Erik suggested:
> 1. Caching the issueProject instances in a map.
> 2. Avoiding using IssueProject as a key in maps.
Marked as reviewed by erikj (Lead).
-------------
PR Review: https://git.openjdk.org/skara/pull/1689#pullrequestreview-2355694001
More information about the skara-dev
mailing list