Integrated: 2386: PullRequestBotFactory creates too many IssueBots

Zhao Song zsong at openjdk.org
Tue Oct 8 23:27:41 UTC 2024


On Tue, 8 Oct 2024 21:19:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Erik found that our bot creates multiple IssueBot instances for a single issue project. And he found that the root cause was the configuration::issueProject method always returning a new instance. Additionally, the equals() and hashcode() methods were not overridden in the JiraProject class.
> 
> This patch is trying to fix this issue as Erik suggested:
> 1. Caching the issueProject instances in a map.
> 2. Avoiding using IssueProject as a key in maps.

This pull request has now been integrated.

Changeset: cf23f68f
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/cf23f68fbf97c7a58d5d8ce1ba8072cc381d7f65
Stats:     22 lines in 1 file changed: 6 ins; 0 del; 16 mod

2386: PullRequestBotFactory creates too many IssueBots

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1689


More information about the skara-dev mailing list