RFR: 2300: Do not list non-OpenJDK reviewers in Reviewers list [v2]

Iris Clark iris at openjdk.org
Tue Oct 22 22:49:21 UTC 2024


On Tue, 22 Oct 2024 22:31:46 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This PR is trying to make skara bot list non-recognized user in a separate section in the PR body.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rename

bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java line 216:

> 214:             // Check that it has been approved
> 215:             assertTrue(authorPr.store().body().contains("Reviewers"));
> 216:             assertTrue(authorPr.store().body().contains("Reviewers without OpenJDK IDs"));

I like how the new title relates to the old while clearly indicating the difference between the two lists.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1693#discussion_r1811531673


More information about the skara-dev mailing list