Integrated: 2401: Link to Webrev should be part of the Reviewing section

Magnus Ihse Bursie ihse at openjdk.org
Wed Oct 30 12:52:11 UTC 2024


On Wed, 30 Oct 2024 11:40:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> When we added the link to the webrev comment in the PR body, for some reason it got its own header `### Webrev`. But Webrevs are just another way of reviewing, so it should be put under the `### Reviewing` header.
> 
> That is, the reviewing html code should look something like this:
> 
> ...
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk/pull/XXX.diff">[https://git.openjdk.org/jdk/pull/XXX.diff</a](https://git.openjdk.org/jdk/pull/XXX.diff%3C/a)>
> 
> </details>
> <details><summary>Using Webrev</summary>
> 
> [Link to Webrev Comment](https://git.openjdk.org/jdk/pull/XXX#issuecomment-YYY)
> 
> </details>

This pull request has now been integrated.

Changeset: 18683e6b
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/18683e6bd6088704bef5587c7c2eeb648b06d743
Stats:     2 lines in 1 file changed: 0 ins; 1 del; 1 mod

2401: Link to Webrev should be part of the Reviewing section

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1695


More information about the skara-dev mailing list