From zsong at openjdk.org Tue Sep 10 21:20:24 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 10 Sep 2024 21:20:24 GMT Subject: RFR: 2367: Customize bot messages based on forge Message-ID: When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. ------------- Commit messages: - SKARA-2367 Changes: https://git.openjdk.org/skara/pull/1685/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1685&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2367 Stats: 30 lines in 4 files changed: 11 ins; 12 del; 7 mod Patch: https://git.openjdk.org/skara/pull/1685.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1685/head:pull/1685 PR: https://git.openjdk.org/skara/pull/1685 From erikj at openjdk.org Wed Sep 11 13:21:32 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 11 Sep 2024 13:21:32 GMT Subject: RFR: 2367: Customize bot messages based on forge In-Reply-To: References: Message-ID: <4an2Pw5Rbqz5zv14L01Jv1jpClZ8JLA-D7XYndoc9Tc=.eb1e2ee2-9031-44ce-a879-c26d09268787@github.com> On Tue, 10 Sep 2024 21:16:05 GMT, Zhao Song wrote: > When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. Since filing this issue, I've realized that it's not really the forge that this needs to be conditional on, but rather which census is configured for the repository. If it's the openjdk census, it doesn't mater which forge the repository is hosted on, we should still post the openjdk message. ------------- PR Comment: https://git.openjdk.org/skara/pull/1685#issuecomment-2343653242 From erikj at openjdk.org Wed Sep 11 13:24:59 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 11 Sep 2024 13:24:59 GMT Subject: RFR: 2367: Customize bot messages based on forge In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 21:16:05 GMT, Zhao Song wrote: > When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. But hm, the part about associating your github username is definitely forge specific. ------------- PR Comment: https://git.openjdk.org/skara/pull/1685#issuecomment-2343661750 From erikj at openjdk.org Wed Sep 11 13:28:11 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 11 Sep 2024 13:28:11 GMT Subject: RFR: 2367: Customize bot messages based on forge In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 21:16:05 GMT, Zhao Song wrote: > When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. Marked as reviewed by erikj (Lead). After thinking some more I think this is good. ------------- PR Review: https://git.openjdk.org/skara/pull/1685#pullrequestreview-2297028033 PR Comment: https://git.openjdk.org/skara/pull/1685#issuecomment-2343672517 From zsong at openjdk.org Wed Sep 11 16:38:33 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Sep 2024 16:38:33 GMT Subject: RFR: 2367: Customize bot messages based on forge In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 21:16:05 GMT, Zhao Song wrote: > When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1685#issuecomment-2344141477 From zsong at openjdk.org Wed Sep 11 16:38:33 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Sep 2024 16:38:33 GMT Subject: Integrated: 2367: Customize bot messages based on forge In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 21:16:05 GMT, Zhao Song wrote: > When an invalid user attempts to issue a Skara command, the Skara bot should print a customized message that is based on the forge. This pull request has now been integrated. Changeset: 49ba4b27 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/49ba4b273fad03822b32db11ec9df27c3c4c0f7b Stats: 30 lines in 4 files changed: 11 ins; 12 del; 7 mod 2367: Customize bot messages based on forge Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1685 From erikj at openjdk.org Tue Sep 17 23:08:34 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 17 Sep 2024 23:08:34 GMT Subject: RFR: 2373: Support repo- style fix versions Message-ID: This patch adds parsing logic for handling version strings on the form "repo-". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them. ------------- Commit messages: - SKARA-2373 Changes: https://git.openjdk.org/skara/pull/1686/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1686&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2373 Stats: 31 lines in 3 files changed: 31 ins; 0 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1686.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1686/head:pull/1686 PR: https://git.openjdk.org/skara/pull/1686 From zsong at openjdk.org Tue Sep 17 23:55:00 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 17 Sep 2024 23:55:00 GMT Subject: RFR: 2373: Support repo- style fix versions In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 23:04:19 GMT, Erik Joelsson wrote: > This patch adds parsing logic for handling version strings on the form "repo-". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them. Looks good jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 82: > 80: // Check for team/project special version > 81: if (finalComponents.isEmpty()) { > 82: var projectRepoPattern = Pattern.compile("repo-([a-z0-9]*)"); For consistency with the surrounding code, would it be better to define this pattern as a static variable? ------------- Marked as reviewed by zsong (Reviewer). PR Review: https://git.openjdk.org/skara/pull/1686#pullrequestreview-2311358982 PR Review Comment: https://git.openjdk.org/skara/pull/1686#discussion_r1764219796 From erikj at openjdk.org Wed Sep 18 14:07:21 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 18 Sep 2024 14:07:21 GMT Subject: RFR: 2373: Support repo- style fix versions [v2] In-Reply-To: References: Message-ID: <1dGzizqvwsjQrViHh1I91fPeEdIdvFlcows98K1bsYU=.af0462cf-57c3-4e24-aed1-58a3d9e85353@github.com> > This patch adds parsing logic for handling version strings on the form "repo-". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them. Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: Review comment ------------- Changes: - all: https://git.openjdk.org/skara/pull/1686/files - new: https://git.openjdk.org/skara/pull/1686/files/a482e449..96bbf720 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1686&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1686&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 1 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1686.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1686/head:pull/1686 PR: https://git.openjdk.org/skara/pull/1686 From erikj at openjdk.org Wed Sep 18 14:07:21 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 18 Sep 2024 14:07:21 GMT Subject: RFR: 2373: Support repo- style fix versions [v2] In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 23:46:46 GMT, Zhao Song wrote: >> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Review comment > > jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 82: > >> 80: // Check for team/project special version >> 81: if (finalComponents.isEmpty()) { >> 82: var projectRepoPattern = Pattern.compile("repo-([a-z0-9]*)"); > > For consistency with the surrounding code, would it be better to define this pattern as a static variable? I thought about that and didn't bother, but you are right. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1686#discussion_r1765120629 From zsong at openjdk.org Wed Sep 18 15:55:31 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 18 Sep 2024 15:55:31 GMT Subject: RFR: 2373: Support repo- style fix versions [v2] In-Reply-To: <1dGzizqvwsjQrViHh1I91fPeEdIdvFlcows98K1bsYU=.af0462cf-57c3-4e24-aed1-58a3d9e85353@github.com> References: <1dGzizqvwsjQrViHh1I91fPeEdIdvFlcows98K1bsYU=.af0462cf-57c3-4e24-aed1-58a3d9e85353@github.com> Message-ID: On Wed, 18 Sep 2024 14:07:21 GMT, Erik Joelsson wrote: >> This patch adds parsing logic for handling version strings on the form "repo-". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them. > > Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: > > Review comment Marked as reviewed by zsong (Reviewer). ------------- PR Review: https://git.openjdk.org/skara/pull/1686#pullrequestreview-2313137129 From erikj at openjdk.org Wed Sep 18 17:10:14 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 18 Sep 2024 17:10:14 GMT Subject: Integrated: 2373: Support repo- style fix versions In-Reply-To: References: Message-ID: On Tue, 17 Sep 2024 23:04:19 GMT, Erik Joelsson wrote: > This patch adds parsing logic for handling version strings on the form "repo-". This form is commonly used in JBS for project repos, but Skara is currently unable to actually parse them. This pull request has now been integrated. Changeset: de726faa Author: Erik Joelsson URL: https://git.openjdk.org/skara/commit/de726faadda279c9c1cc505482f8bcfedea9bd42 Stats: 32 lines in 3 files changed: 32 ins; 0 del; 0 mod 2373: Support repo- style fix versions Reviewed-by: zsong ------------- PR: https://git.openjdk.org/skara/pull/1686 From zsong at openjdk.org Fri Sep 27 17:52:29 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 27 Sep 2024 17:52:29 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR Message-ID: PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. ------------- Commit messages: - SKARA-2328 Changes: https://git.openjdk.org/skara/pull/1687/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1687&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2328 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1687.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1687/head:pull/1687 PR: https://git.openjdk.org/skara/pull/1687 From erikj at openjdk.org Fri Sep 27 18:09:20 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Fri, 27 Sep 2024 18:09:20 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR In-Reply-To: References: Message-ID: <9jP6S8GlTxNrv_tx47Gy-52i7X0MDIGmW5WZiEr6rS8=.4044c90c-ceb6-4c68-844d-45e62aff3a12@github.com> On Fri, 27 Sep 2024 17:48:10 GMT, Zhao Song wrote: > PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. This change will only make the bot ignore comments from the particular user (or actually "app") this bot uses, which in practice won't change anything as the bridgekeeper bot uses a different app compared to the pr bot. To solve this properly we need to add a configuration for "ignored", like several other bots have, so we can list all users that should be ignored by the pruner. See mlbridge for an example. ------------- PR Comment: https://git.openjdk.org/skara/pull/1687#issuecomment-2379805582 From zsong at openjdk.org Fri Sep 27 18:13:15 2024 From: zsong at openjdk.org (Zhao Song) Date: Fri, 27 Sep 2024 18:13:15 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR In-Reply-To: <9jP6S8GlTxNrv_tx47Gy-52i7X0MDIGmW5WZiEr6rS8=.4044c90c-ceb6-4c68-844d-45e62aff3a12@github.com> References: <9jP6S8GlTxNrv_tx47Gy-52i7X0MDIGmW5WZiEr6rS8=.4044c90c-ceb6-4c68-844d-45e62aff3a12@github.com> Message-ID: On Fri, 27 Sep 2024 18:07:01 GMT, Erik Joelsson wrote: > This change will only make the bot ignore comments from the particular user (or actually "app") this bot uses, which in practice won't change anything as the bridgekeeper bot uses a different app compared to the pr bot. To solve this properly we need to add a configuration for "ignored", like several other bots have, so we can list all users that should be ignored by the pruner. See mlbridge for an example. Ah right, I forgot this bot is using a different user... Will fix it, thanks for catching it. ------------- PR Comment: https://git.openjdk.org/skara/pull/1687#issuecomment-2379812302 From zsong at openjdk.org Mon Sep 30 20:19:35 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 30 Sep 2024 20:19:35 GMT Subject: RFR: 2328: Ignore bot user's comment when determining the latest action time of a PR [v2] In-Reply-To: References: Message-ID: > PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/skara/pull/1687/files - new: https://git.openjdk.org/skara/pull/1687/files/bc145c9f..e189bbfc Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1687&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1687&range=00-01 Stats: 51 lines in 4 files changed: 31 ins; 0 del; 20 mod Patch: https://git.openjdk.org/skara/pull/1687.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1687/head:pull/1687 PR: https://git.openjdk.org/skara/pull/1687