Integrated: 2470: Mailing list bridge is failing to send some emails

[Erik Joelsson]

On Mon, 7 Apr 2025 22:09:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The mlbridge bot sometimes fails to send emails based on PR activity/comments. The emails get generated and the bot attempts to store them in the mailing list archive repo, which we are storing in a GitLab server. The PUT call returns 400, which the bot interprets as a failure and aborts the WorkItem. On the next run of that WorkItem, the emails are found in the archive, which the bot interprets as having been sent, so no new attempt is made. The issue here is that GitLab returns a failure code but still stores the data.
> 
> To try to work around this, I'm adding a fallback check when receiving 400 when storing a file. The check tries to fetch the current contents of the file and compares it to what we attempted to store. If equal, the error is ignored and the store procedure is considered successful.
> 
> Testing this is tricky, so this code is basically untested. I'm also adding more logging and more information to existing related logging so that we can monitor this behavior better and see if this workaround is having any effect.

This pull request has now been integrated.

Changeset: 40bd8896
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/40bd889665ae8227b34c4b5a787320e27721b57c
Stats:     22 lines in 3 files changed: 17 ins; 1 del; 4 mod

2470: Mailing list bridge is failing to send some emails

Reviewed-by: zsong

-------------

PR: https://git.openjdk.org/skara/pull/1713