RFR: 2479: PR marked as ready with jcheck error

[Erik Joelsson]

On Thu, 17 Apr 2025 17:32:48 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, when determining if a PR is ready, if the PR doesn't require a review, it also ignores all jcheck failures. Instead, only reviewers check should be ignored in this case.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1473:

> 1471: 
> 1472:             var onlyReviewersCheckFailed = visitor.errorFailedChecksMessages().stream()
> 1473:                     .allMatch(message -> message.contains("Too few reviewers"));

This looks awkward. Can we extend the Visitor with an explicit method for this instead? The role of the Visitor implementation is to gather the jcheck errors and present them in a way that makes sense to the caller, in this case the pr bot classes.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2049416832