RFR: 2479: PR marked as ready with jcheck error [v3]

Zhao Song zsong at openjdk.org
Thu Apr 17 21:40:47 UTC 2025


> Currently, when determining if a PR is ready, if the PR doesn't require a review, it also ignores all jcheck failures. Instead, only reviewers check should be ignored in this case.

Zhao Song has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - review comment
 - Merge branch 'master' into SKARA-2479
 - review comment
 - add test
 - update
 - SKARA-2479

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1714/files
  - new: https://git.openjdk.org/skara/pull/1714/files/18043ee6..28f368b0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1714&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1714&range=01-02

  Stats: 11 lines in 3 files changed: 2 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1714.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1714/head:pull/1714

PR: https://git.openjdk.org/skara/pull/1714


More information about the skara-dev mailing list