From erikj at openjdk.org  Fri Aug  1 19:37:18 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 1 Aug 2025 19:37:18 GMT
Subject: RFR: 2510: Bug closed due to inactivity even though there was
 "activity"
In-Reply-To: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
References: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
Message-ID: <Xk29J_iFCiGmXeYlh-OxPUA_2C96Ez2p_PBNPnCLzHs=.8e305dde-042b-4f5b-887c-44374dd3be52@github.com>

On Wed, 2 Jul 2025 18:26:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, the PullRequestPrunerBot considers only comments, reviews, and review comments as activity. Therefore, it can sometimes mistakenly close a user's pull request.
> 
> In this patch, I am trying to let PullRequestPrunerBot counts commits, pr state changes as valid activities.

Looks good!

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1723#pullrequestreview-3080364953

From zsong at openjdk.org  Fri Aug  1 19:53:24 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 1 Aug 2025 19:53:24 GMT
Subject: RFR: 2408: Require at least one component/area label before a PR can
 be integrated
Message-ID: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>

This patch is trying to improve the bot by ensuring that if the repo has the label configuration, then any pull request in this repo should only be marked as "rfr" when at least one component is associated with the pr.

-------------

Commit messages:
 - update
 - SKARA-2048

Changes: https://git.openjdk.org/skara/pull/1727/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1727&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2408
  Stats: 14 lines in 2 files changed: 11 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/skara/pull/1727.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1727/head:pull/1727

PR: https://git.openjdk.org/skara/pull/1727

From zsong at openjdk.org  Fri Aug  1 19:53:35 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 1 Aug 2025 19:53:35 GMT
Subject: RFR: 2527: Sponsored commits may get wrong author
Message-ID: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>

When determining the author of a commit, if the author of pr doesn't have OpenJDK Id, the bot falls back to use the author from the last commit of the pr, in this way, the bot may give credit to the wrong person. 
In this patch, if the author of pr doesn't have OpenJDK Id, the bot will try to parse full name and email from the forge first, if it fails, then it will fall back to use the author of the last commit.

-------------

Commit messages:
 - SKARA-2527

Changes: https://git.openjdk.org/skara/pull/1726/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1726&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2527
  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1726.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1726/head:pull/1726

PR: https://git.openjdk.org/skara/pull/1726

From zsong at openjdk.org  Mon Aug  4 17:53:41 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 4 Aug 2025 17:53:41 GMT
Subject: RFR: 2510: Bug closed due to inactivity even though there was
 "activity"
In-Reply-To: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
References: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
Message-ID: <VKdiiGfptdBgUAwz8yedbu2geg93GjQ2d-2jeKFOzAo=.2668690a-4f93-4eff-8546-6f9c7e2b1964@github.com>

On Wed, 2 Jul 2025 18:26:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, the PullRequestPrunerBot considers only comments, reviews, and review comments as activity. Therefore, it can sometimes mistakenly close a user's pull request.
> 
> In this patch, I am trying to let PullRequestPrunerBot counts commits, pr state changes as valid activities.

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1723#issuecomment-3151812575

From zsong at openjdk.org  Mon Aug  4 17:53:41 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 4 Aug 2025 17:53:41 GMT
Subject: Integrated: 2510: Bug closed due to inactivity even though there was
 "activity"
In-Reply-To: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
References: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com>
Message-ID: <uD7HcPNrj8BTmCaW3wPX3BvfCDog8PrJEkWA19Upzj0=.4fff1c30-fdad-4c4e-b9ed-e161ffb453c6@github.com>

On Wed, 2 Jul 2025 18:26:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, the PullRequestPrunerBot considers only comments, reviews, and review comments as activity. Therefore, it can sometimes mistakenly close a user's pull request.
> 
> In this patch, I am trying to let PullRequestPrunerBot counts commits, pr state changes as valid activities.

This pull request has now been integrated.

Changeset: 374f7551
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/374f7551161810e97bb6331c8598f342e529e4d3
Stats:     135 lines in 12 files changed: 123 ins; 0 del; 12 mod

2510: Bug closed due to inactivity even though there was "activity"

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1723

From erikj at openjdk.org  Tue Aug  5 12:08:39 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 5 Aug 2025 12:08:39 GMT
Subject: RFR: 2408: Require at least one component/area label before a PR
 can be integrated
In-Reply-To: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
References: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
Message-ID: <pctxbFIqxnPsK9kYE2E7M5rBvF6t1Yg2Yf6qvZF3Q5s=.760c32cb-c93b-4805-921f-08e2b2f59056@github.com>

On Thu, 31 Jul 2025 21:46:26 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to improve the bot by ensuring that if the repo has the label configuration, then any pull request in this repo should only be marked as "rfr" when at least one component is associated with the pr.

That was simpler than I thought it would be. Looks good!

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1727#pullrequestreview-3087999243

From erikj at openjdk.org  Tue Aug  5 12:10:13 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 5 Aug 2025 12:10:13 GMT
Subject: RFR: 2527: Sponsored commits may get wrong author
In-Reply-To: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
References: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
Message-ID: <HT9SV2QqaJ7pB8tasb0lcKFg0Pe3iGk5L6BdDEoF5RE=.91735b40-3b40-4754-a1c4-bbb71a2640b5@github.com>

On Thu, 17 Jul 2025 21:11:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When determining the author of a commit, if the author of pr doesn't have OpenJDK Id, the bot falls back to use the author from the last commit of the pr, in this way, the bot may give credit to the wrong person. 
> In this patch, if the author of pr doesn't have OpenJDK Id, the bot will try to parse full name and email from the forge first, if it fails, then it will fall back to use the author of the last commit.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1726#pullrequestreview-3088004245

From zsong at openjdk.org  Tue Aug  5 16:41:27 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 5 Aug 2025 16:41:27 GMT
Subject: RFR: 2527: Sponsored commits may get wrong author
In-Reply-To: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
References: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
Message-ID: <2NHpen8doPtMD_kVBjSvVG5CJwtY6cr_hrKg6jAJD44=.cf25dd98-6758-4732-bca0-f6445e65bd45@github.com>

On Thu, 17 Jul 2025 21:11:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When determining the author of a commit, if the author of pr doesn't have OpenJDK Id, the bot falls back to use the author from the last commit of the pr, in this way, the bot may give credit to the wrong person. 
> In this patch, if the author of pr doesn't have OpenJDK Id, the bot will try to parse full name and email from the forge first, if it fails, then it will fall back to use the author of the last commit.

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1726#issuecomment-3155855176

From zsong at openjdk.org  Tue Aug  5 16:41:27 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 5 Aug 2025 16:41:27 GMT
Subject: Integrated: 2527: Sponsored commits may get wrong author
In-Reply-To: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
References: <yzLfOx4lwM8lIzl59nf-ykZ_Tc535VdJvq3H3lpB_Ew=.7d3b3a12-e4d7-416f-8f9e-4258e6c79457@github.com>
Message-ID: <NxC9I-TLTbgfRiQ78-1YmVSIZemJEeoFEbTLCcYfaYc=.0d3e386c-609c-4a13-ad36-a95e0c7cd436@github.com>

On Thu, 17 Jul 2025 21:11:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When determining the author of a commit, if the author of pr doesn't have OpenJDK Id, the bot falls back to use the author from the last commit of the pr, in this way, the bot may give credit to the wrong person. 
> In this patch, if the author of pr doesn't have OpenJDK Id, the bot will try to parse full name and email from the forge first, if it fails, then it will fall back to use the author of the last commit.

This pull request has now been integrated.

Changeset: 5400a26c
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/5400a26c577b08ff958e62134edaca01a532deed
Stats:     6 lines in 1 file changed: 4 ins; 0 del; 2 mod

2527: Sponsored commits may get wrong author

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1726

From zsong at openjdk.org  Tue Aug  5 16:47:13 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 5 Aug 2025 16:47:13 GMT
Subject: RFR: 2408: Require at least one component/area label before a PR
 can be integrated
In-Reply-To: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
References: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
Message-ID: <ogew9yTnYl846TQ60maZxK9a6zkTtdtbc6ksN_N1T-M=.64e266d4-bc16-4613-ae4c-493871f3ace2@github.com>

On Thu, 31 Jul 2025 21:46:26 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to improve the bot by ensuring that if the repo has the label configuration, then any pull request in this repo should only be marked as "rfr" when at least one component is associated with the pr.

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1727#issuecomment-3155870958

From zsong at openjdk.org  Tue Aug  5 16:47:13 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 5 Aug 2025 16:47:13 GMT
Subject: Integrated: 2408: Require at least one component/area label before a
 PR can be integrated
In-Reply-To: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
References: <mPn0h64gk7o-InA0xnTbGfR3JkAMtZwiVziLIa8NAVE=.44f5b289-5c82-467f-a2b3-14d9d4a2acbb@github.com>
Message-ID: <nkqj3RNBMUHfvGbCYwSvanbstGQhzEyVudHxIfqy3HU=.20aace13-f27e-42bd-9418-ab18bd458bb8@github.com>

On Thu, 31 Jul 2025 21:46:26 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to improve the bot by ensuring that if the repo has the label configuration, then any pull request in this repo should only be marked as "rfr" when at least one component is associated with the pr.

This pull request has now been integrated.

Changeset: f8e06d95
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/f8e06d95bdec0634dd3d4b0f471e26be86da8d4f
Stats:     14 lines in 2 files changed: 11 ins; 0 del; 3 mod

2408: Require at least one component/area label before a PR can be integrated

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1727

From zsong at openjdk.org  Tue Aug  5 21:08:46 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 5 Aug 2025 21:08:46 GMT
Subject: RFR: 2552: Followup of SKARA-2408
Message-ID: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>

[SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) is not working as expected since the first CheckWorkItem is processed before LabelerWorkItem. Therefore, the logic I added in [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) won't stop the bot from adding "rfr" label in the firstCheckWorkItem.

Currently, If a pr is not associated with any component, the bot will
1. Add "rfr" label in the first CheckWorkItem
2. Execute the LabelerWorkItem
3. In the next CheckWorkItem, it will remove the "rfr" label

This will cause a race between mlbridgeBot and prBot.

-------------

Commit messages:
 - update
 - update
 - SKARA-2552

Changes: https://git.openjdk.org/skara/pull/1728/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1728&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2552
  Stats: 35 lines in 5 files changed: 21 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/skara/pull/1728.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1728/head:pull/1728

PR: https://git.openjdk.org/skara/pull/1728

From erikj at openjdk.org  Wed Aug  6 12:36:53 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 6 Aug 2025 12:36:53 GMT
Subject: RFR: 2552: Followup of SKARA-2408
In-Reply-To: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
References: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
Message-ID: <aYg1QlbGIbecBxmP6amEwtwvjaUNUqXvOSXUiNxbgd4=.d0e2a6a3-b27f-45c2-880b-3d6885590de1@github.com>

On Tue, 5 Aug 2025 17:56:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) is not working as expected since the first CheckWorkItem is processed before LabelerWorkItem. Therefore, the logic I added in [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) won't stop the bot from adding "rfr" label in the firstCheckWorkItem.
> 
> Currently, If a pr is not associated with any component, the bot will
> 1. Add "rfr" label in the first CheckWorkItem
> 2. Execute the LabelerWorkItem
> 3. In the next CheckWorkItem, it will remove the "rfr" label
> 
> This will cause a race between mlbridgeBot and prBot.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1728#pullrequestreview-3092340142

From zsong at openjdk.org  Wed Aug  6 16:47:53 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 6 Aug 2025 16:47:53 GMT
Subject: RFR: 2552: Followup of SKARA-2408
In-Reply-To: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
References: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
Message-ID: <xOyWdzGJ1M-htawEZpnEt-AFn_Qhk88lWVQyKexcw7Y=.3d9672a8-b099-44c7-abb9-2e678c58a902@github.com>

On Tue, 5 Aug 2025 17:56:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) is not working as expected since the first CheckWorkItem is processed before LabelerWorkItem. Therefore, the logic I added in [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) won't stop the bot from adding "rfr" label in the firstCheckWorkItem.
> 
> Currently, If a pr is not associated with any component, the bot will
> 1. Add "rfr" label in the first CheckWorkItem
> 2. Execute the LabelerWorkItem
> 3. In the next CheckWorkItem, it will remove the "rfr" label
> 
> This will cause a race between mlbridgeBot and prBot.

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1728#issuecomment-3160868244

From zsong at openjdk.org  Wed Aug  6 16:47:53 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 6 Aug 2025 16:47:53 GMT
Subject: Integrated: 2552: Followup of SKARA-2408
In-Reply-To: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
References: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
Message-ID: <kwlZfFK4JRasCUcO7WDw1K2MCuJfx9cqPgvBKUcMjRU=.cbb70a6b-975e-489f-8c5d-b74e0ce50752@github.com>

On Tue, 5 Aug 2025 17:56:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) is not working as expected since the first CheckWorkItem is processed before LabelerWorkItem. Therefore, the logic I added in [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) won't stop the bot from adding "rfr" label in the firstCheckWorkItem.
> 
> Currently, If a pr is not associated with any component, the bot will
> 1. Add "rfr" label in the first CheckWorkItem
> 2. Execute the LabelerWorkItem
> 3. In the next CheckWorkItem, it will remove the "rfr" label
> 
> This will cause a race between mlbridgeBot and prBot.

This pull request has now been integrated.

Changeset: 44525446
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/44525446bd352876b031fced51048295e5d8b1a4
Stats:     35 lines in 5 files changed: 21 ins; 0 del; 14 mod

2552: Followup of SKARA-2408

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1728

From zsong at openjdk.org  Wed Aug  6 21:40:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 6 Aug 2025 21:40:52 GMT
Subject: RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot
 restarts
Message-ID: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>

In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.

Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.

Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.

-------------

Commit messages:
 - update
 - update
 - SKARA-2556

Changes: https://git.openjdk.org/skara/pull/1729/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1729&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2556
  Stats: 5 lines in 1 file changed: 1 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/skara/pull/1729.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1729/head:pull/1729

PR: https://git.openjdk.org/skara/pull/1729

From erikj at openjdk.org  Wed Aug  6 21:41:24 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 6 Aug 2025 21:41:24 GMT
Subject: RFR: 2552: Followup of SKARA-2408
In-Reply-To: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
References: <RgmJST9VzcwcwFJVinhf0CLk2B7EzH45P2iiBLIvQbY=.47aad42c-d8f1-4178-8c11-9d9747c4ce2e@github.com>
Message-ID: <rmZh95DFAkke38RYGQDPUnId1yO4Nz5w0Ttb90yRvLs=.335fb62b-c3e6-4ade-84dc-bb8b9ab2540c@github.com>

On Tue, 5 Aug 2025 17:56:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) is not working as expected since the first CheckWorkItem is processed before LabelerWorkItem. Therefore, the logic I added in [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) won't stop the bot from adding "rfr" label in the firstCheckWorkItem.
> 
> Currently, If a pr is not associated with any component, the bot will
> 1. Add "rfr" label in the first CheckWorkItem
> 2. Execute the LabelerWorkItem
> 3. In the next CheckWorkItem, it will remove the "rfr" label
> 
> This will cause a race between mlbridgeBot and prBot.

I saw your comment elsewhere that this had a big performance impact. Added some suggestions to alleviate that.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java line 125:

> 123:         if (bot.labelConfiguration().allowed().isEmpty()) {
> 124:             bot.setAutoLabelled(pr);
> 125:             return List.of(CheckWorkItem.fromWorkItemWithForceUpdate(bot, prId, errorHandler, triggerUpdatedAt));

We shouldn't need to rerun CheckWorkItem here.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java line 136:

> 134:         if (manuallyAdded.size() > 0 || manuallyRemoved.size() > 0) {
> 135:             bot.setAutoLabelled(pr);
> 136:             return List.of(CheckWorkItem.fromWorkItemWithForceUpdate(bot, prId, errorHandler, triggerUpdatedAt));

For the rest of these, they are only needed if the PR doesn't have `rfr` I think.

-------------

PR Review: https://git.openjdk.org/skara/pull/1728#pullrequestreview-3094394293
PR Review Comment: https://git.openjdk.org/skara/pull/1728#discussion_r2258368581
PR Review Comment: https://git.openjdk.org/skara/pull/1728#discussion_r2258375062

From erikj at openjdk.org  Wed Aug  6 21:47:13 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 6 Aug 2025 21:47:13 GMT
Subject: RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot
 restarts
In-Reply-To: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
References: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
Message-ID: <BSuuPcTUbtqNFJ_MBU7FnJAH9iw6oF2mVqNMpCgci94=.ffb76e4e-b566-48a3-829c-9505c6b1ae55@github.com>

On Wed, 6 Aug 2025 21:11:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
> 
> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
> 
> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java line 125:

> 123: 
> 124:         if (bot.isAutoLabelled(pr) || pr.isClosed()) {
> 125:             return List.of();

Having this check is good, but I think we should also check `!pr.isClosed()` before even creating a `LablerWorkItem` in `PullRequestCommandWorkItem`. That should help alleviate even more startup congestion.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1729#discussion_r2258385903

From zsong at openjdk.org  Wed Aug  6 22:04:36 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 6 Aug 2025 22:04:36 GMT
Subject: RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot
 restarts [v2]
In-Reply-To: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
References: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
Message-ID: <h7pNCPXtuCB4wIZZfGpqpWFM8hx80yM19tj1k_-wXRE=.657cadb2-95d1-4498-94cc-63229785ad3e@github.com>

> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
> 
> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
> 
> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1729/files
  - new: https://git.openjdk.org/skara/pull/1729/files/7d4aa190..072997bf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1729&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1729&range=00-01

  Stats: 18 lines in 2 files changed: 9 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1729.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1729/head:pull/1729

PR: https://git.openjdk.org/skara/pull/1729

From erikj at openjdk.org  Wed Aug  6 22:49:17 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 6 Aug 2025 22:49:17 GMT
Subject: RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot
 restarts [v2]
In-Reply-To: <h7pNCPXtuCB4wIZZfGpqpWFM8hx80yM19tj1k_-wXRE=.657cadb2-95d1-4498-94cc-63229785ad3e@github.com>
References: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
 <h7pNCPXtuCB4wIZZfGpqpWFM8hx80yM19tj1k_-wXRE=.657cadb2-95d1-4498-94cc-63229785ad3e@github.com>
Message-ID: <V49PYeN_7_zAv2OyirvgwLi-WqbLK8RGmSRuJyWgIfo=.d6c70af0-cf44-40d3-9330-7c70eebc24d1@github.com>

On Wed, 6 Aug 2025 22:04:36 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
>> 
>> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
>> 
>> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1729#pullrequestreview-3094529379

From zsong at openjdk.org  Thu Aug  7 16:17:25 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 7 Aug 2025 16:17:25 GMT
Subject: RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot
 restarts [v2]
In-Reply-To: <h7pNCPXtuCB4wIZZfGpqpWFM8hx80yM19tj1k_-wXRE=.657cadb2-95d1-4498-94cc-63229785ad3e@github.com>
References: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
 <h7pNCPXtuCB4wIZZfGpqpWFM8hx80yM19tj1k_-wXRE=.657cadb2-95d1-4498-94cc-63229785ad3e@github.com>
Message-ID: <11TzFnDivfZrCXZtf4bNK3FfX1F0buAugSQBbR4Bjrc=.2b83f865-b370-4c0d-99a3-13a40056c810@github.com>

On Wed, 6 Aug 2025 22:04:36 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
>> 
>> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
>> 
>> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1729#issuecomment-3164886662

From zsong at openjdk.org  Thu Aug  7 16:17:26 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 7 Aug 2025 16:17:26 GMT
Subject: Integrated: 2556: LablerWorkItem adds unnecessary overhead when the
 bot restarts
In-Reply-To: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
References: <NuSREi1jGbbvk-EdqK1gcH2MVanZIOuAKmYoRQjXr78=.e636ffc5-1bce-4748-8b1f-a2a5e6ce6a2e@github.com>
Message-ID: <CPuYyH_O48BanzDLrQG5gVQj7AMYEnv6zWGXPqRlnsg=.7fc7ae9b-c225-45d1-8751-f4bf8251fbde@github.com>

On Wed, 6 Aug 2025 21:11:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
> 
> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
> 
> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.

This pull request has now been integrated.

Changeset: becf9411
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/becf941128bca39facba3e30723f031f700f8ab6
Stats:     15 lines in 2 files changed: 8 ins; 0 del; 7 mod

2556: LablerWorkItem adds unnecessary overhead when the bot restarts

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1729

From zsong at openjdk.org  Thu Aug  7 21:24:37 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 7 Aug 2025 21:24:37 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues
Message-ID: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>

This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

-------------

Commit messages:
 - SKARA-2557

Changes: https://git.openjdk.org/skara/pull/1730/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2557
  Stats: 18 lines in 1 file changed: 7 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/skara/pull/1730.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1730/head:pull/1730

PR: https://git.openjdk.org/skara/pull/1730

From erikj at openjdk.org  Thu Aug  7 21:34:57 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 7 Aug 2025 21:34:57 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues
In-Reply-To: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
Message-ID: <-3zGRkDSpzfhmsInoUXnXJyXEZnBBvqefuBX5vYSJQo=.28966ccd-2ee6-490e-bd97-62e7de6d4c5d@github.com>

On Thu, 7 Aug 2025 21:18:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

I think this change warrants a new manual integration test.

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 246:

> 244:                 .put("transition", JSON.object()
> 245:                         .put("id", id));
> 246:         if (state.equals("RESOLVED")) {

This method is called with `"Resolved"` not `"RESOLVED"`. To avoid relying on string comparisons here, could we make all the calls to this method use constants, or perhaps even an internal enum?

-------------

PR Review: https://git.openjdk.org/skara/pull/1730#pullrequestreview-3098792848
PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2261449607

From zsong at openjdk.org  Thu Aug  7 21:44:19 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 7 Aug 2025 21:44:19 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues
In-Reply-To: <-3zGRkDSpzfhmsInoUXnXJyXEZnBBvqefuBX5vYSJQo=.28966ccd-2ee6-490e-bd97-62e7de6d4c5d@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <-3zGRkDSpzfhmsInoUXnXJyXEZnBBvqefuBX5vYSJQo=.28966ccd-2ee6-490e-bd97-62e7de6d4c5d@github.com>
Message-ID: <OwCdng33T9DZdYemObLH_aWPoVDtJwg7TCVrYBID7yY=.6015cc42-cb86-4dc6-af62-531dfb45fbcc@github.com>

On Thu, 7 Aug 2025 21:32:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I think this change warrants a new manual integration test.

I did it but didn't commit the change, will do.

> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 246:
> 
>> 244:                 .put("transition", JSON.object()
>> 245:                         .put("id", id));
>> 246:         if (state.equals("RESOLVED")) {
> 
> This method is called with `"Resolved"` not `"RESOLVED"`. To avoid relying on string comparisons here, could we make all the calls to this method use constants, or perhaps even an internal enum?

Sure

-------------

PR Comment: https://git.openjdk.org/skara/pull/1730#issuecomment-3165847337
PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2261475102

From zsong at openjdk.org  Thu Aug  7 21:58:34 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 7 Aug 2025 21:58:34 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v2]
In-Reply-To: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
Message-ID: <N5gQZ-AuXph_wmvF_ph8eDR31Dw0qbNp9lVwTXLHJRQ=.ac7de56c-f154-4a34-afbe-7b3d19e3dd5d@github.com>

> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1730/files
  - new: https://git.openjdk.org/skara/pull/1730/files/1b444e02..0c5a5c79

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=00-01

  Stats: 37 lines in 3 files changed: 19 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/skara/pull/1730.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1730/head:pull/1730

PR: https://git.openjdk.org/skara/pull/1730

From zsong at openjdk.org  Fri Aug  8 17:24:19 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 8 Aug 2025 17:24:19 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
Message-ID: <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>

> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

Zhao Song has updated the pull request incrementally with two additional commits since the last revision:

 - update
 - rename method

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1730/files
  - new: https://git.openjdk.org/skara/pull/1730/files/0c5a5c79..c4e635fb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=01-02

  Stats: 32 lines in 3 files changed: 7 ins; 9 del; 16 mod
  Patch: https://git.openjdk.org/skara/pull/1730.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1730/head:pull/1730

PR: https://git.openjdk.org/skara/pull/1730

From erikj at openjdk.org  Fri Aug  8 17:24:19 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 8 Aug 2025 17:24:19 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
Message-ID: <Rfi3ged3arHi9vBHh2TaC3HlHwpgR43BUR9F7FWdp48=.431cc9b3-36d6-4e22-9a8d-fde0950a72bc@github.com>

On Fri, 8 Aug 2025 17:21:29 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update
>  - rename method

issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java line 126:

> 124:             String name = name().toLowerCase();
> 125:             return name.substring(0, 1).toUpperCase() + name.substring(1);
> 126:         }

The string representation for Jira should probably be handled as a Jira specific thing. I don't think we should pollute the general IssueTracker implementation with Jira specifics. My intention was to create a new enum or set of constants within the Jira package.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2263044412

From zsong at openjdk.org  Fri Aug  8 17:24:19 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 8 Aug 2025 17:24:19 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <Rfi3ged3arHi9vBHh2TaC3HlHwpgR43BUR9F7FWdp48=.431cc9b3-36d6-4e22-9a8d-fde0950a72bc@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
 <Rfi3ged3arHi9vBHh2TaC3HlHwpgR43BUR9F7FWdp48=.431cc9b3-36d6-4e22-9a8d-fde0950a72bc@github.com>
Message-ID: <1w_SwgNTLWVv7GFQaiPKf9empIs6zKP7VPVLuHWUJ0c=.2ec88448-1c20-4f04-badc-314a94e3d193@github.com>

On Fri, 8 Aug 2025 13:51:46 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update
>>  - rename method
>
> issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java line 126:
> 
>> 124:             String name = name().toLowerCase();
>> 125:             return name.substring(0, 1).toUpperCase() + name.substring(1);
>> 126:         }
> 
> The string representation for Jira should probably be handled as a Jira specific thing. I don't think we should pollute the general IssueTracker implementation with Jira specifics. My intention was to create a new enum or set of constants within the Jira package.

Will fix it, thanks!

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2263450445

From zsong at openjdk.org  Mon Aug 11 23:08:07 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 11 Aug 2025 23:08:07 GMT
Subject: RFR: 2562: Disable backport command in open pull requests until Github
 allows the bot to create labels
Message-ID: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>

In [SKARA-1797](https://bugs.openjdk.org/browse/SKARA-1797), the bot was enhanced to support backport pull request command, but with the implementation, the bot needs to add a customized label to the pull request. Recently, Github did some changes and it no longer allows the bot to create new labels. I need to disable this feature until Github allows the bot to create new labels again.

-------------

Commit messages:
 - SKARA-2562

Changes: https://git.openjdk.org/skara/pull/1731/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1731&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2562
  Stats: 97 lines in 3 files changed: 5 ins; 0 del; 92 mod
  Patch: https://git.openjdk.org/skara/pull/1731.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1731/head:pull/1731

PR: https://git.openjdk.org/skara/pull/1731

From erikj at openjdk.org  Tue Aug 12 20:01:39 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 12 Aug 2025 20:01:39 GMT
Subject: RFR: 2562: Disable backport command in open pull requests until
 Github allows the bot to create labels
In-Reply-To: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
References: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
Message-ID: <9EfTXHSu0foLSq4OfkS4Nutz8enwdDZbyG5N5SmMpmw=.1ca4f7a1-2190-4cf5-9d59-4e317a7f869b@github.com>

On Mon, 11 Aug 2025 23:04:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1797](https://bugs.openjdk.org/browse/SKARA-1797), the bot was enhanced to support backport pull request command, but with the implementation, the bot needs to add a customized label to the pull request. Recently, Github did some changes and it no longer allows the bot to create new labels. I need to disable this feature until Github allows the bot to create new labels again.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1731#pullrequestreview-3112576990

From kcr at openjdk.org  Tue Aug 12 22:17:58 2025
From: kcr at openjdk.org (Kevin Rushforth)
Date: Tue, 12 Aug 2025 22:17:58 GMT
Subject: RFR: 2562: Disable backport command in open pull requests until
 Github allows the bot to create labels
In-Reply-To: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
References: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
Message-ID: <JFfP3axXDBupnsrtPUWgJjYtJGrYHvT_u7v7d1zUk9U=.686cf8c4-7247-4ccc-aaee-bcd3ad8a1ddd@github.com>

On Mon, 11 Aug 2025 23:04:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1797](https://bugs.openjdk.org/browse/SKARA-1797), the bot was enhanced to support backport pull request command, but with the implementation, the bot needs to add a customized label to the pull request. Recently, Github did some changes and it no longer allows the bot to create new labels. I need to disable this feature until Github allows the bot to create new labels again.

@zhaosongzs As discussed offline, this might no longer be needed. Please check and let me know.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1731#issuecomment-3181193739

From zsong at openjdk.org  Wed Aug 13 17:52:31 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 13 Aug 2025 17:52:31 GMT
Subject: RFR: 2562: Disable backport command in open pull requests until
 Github allows the bot to create labels
In-Reply-To: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
References: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
Message-ID: <mJAG36xGsvaGjIEYgBg_hFg_igUCv-XSIbdtisNg3H4=.be4f7596-edef-473d-b38b-6759d6407f6d@github.com>

On Mon, 11 Aug 2025 23:04:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1797](https://bugs.openjdk.org/browse/SKARA-1797), the bot was enhanced to support backport pull request command, but with the implementation, the bot needs to add a customized label to the pull request. Recently, Github did some changes and it no longer allows the bot to create new labels. I need to disable this feature until Github allows the bot to create new labels again.

I have verified that the issue has been resolved and the bot can create new labels.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1731#issuecomment-3184888253

From zsong at openjdk.org  Wed Aug 13 17:52:31 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 13 Aug 2025 17:52:31 GMT
Subject: Withdrawn: 2562: Disable backport command in open pull requests until
 Github allows the bot to create labels
In-Reply-To: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
References: <aexG_GS8JXk8wgUnWw1YblpFyJTeBn25MnEYkU4QIhQ=.315fd922-156d-4779-bf9d-acfff8a818c4@github.com>
Message-ID: <ghFoYlTmkvk-UnjzK6Cd4dGN032Yid2A9Cfld6Awx0Q=.7eaab807-a0ef-4a69-a098-de914e37e25d@github.com>

On Mon, 11 Aug 2025 23:04:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1797](https://bugs.openjdk.org/browse/SKARA-1797), the bot was enhanced to support backport pull request command, but with the implementation, the bot needs to add a customized label to the pull request. Recently, Github did some changes and it no longer allows the bot to create new labels. I need to disable this feature until Github allows the bot to create new labels again.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/skara/pull/1731

From erikj at openjdk.org  Fri Aug 15 17:35:37 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 15 Aug 2025 17:35:37 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
Message-ID: <qV1z66K5N1OmEtnXNYtG-CD1KhAAVrZefvTYfZjP2QI=.283e6410-3482-40bc-ac4b-8fc3bdeea2db@github.com>

On Fri, 8 Aug 2025 17:24:19 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update
>  - rename method

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 248:

> 246: 
> 247:     private void performTransition(JiraIssueState state) {
> 248:         var id = availableTransitions.get(state.name());

I think either get both state and transition id as parameters, or supply the availableTransitions map as a parameter. I don't think we should store it as a field.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2279555712

From zsong at openjdk.org  Fri Aug 15 17:40:15 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 15 Aug 2025 17:40:15 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <qV1z66K5N1OmEtnXNYtG-CD1KhAAVrZefvTYfZjP2QI=.283e6410-3482-40bc-ac4b-8fc3bdeea2db@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
 <qV1z66K5N1OmEtnXNYtG-CD1KhAAVrZefvTYfZjP2QI=.283e6410-3482-40bc-ac4b-8fc3bdeea2db@github.com>
Message-ID: <3Ci3qtpjWdKI5xYZS2OJb5el6yOtb8VUkercfkcw_BQ=.bce14740-dc8b-44f6-84ac-061e8aed9606@github.com>

On Fri, 15 Aug 2025 17:32:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update
>>  - rename method
>
> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 248:
> 
>> 246: 
>> 247:     private void performTransition(JiraIssueState state) {
>> 248:         var id = availableTransitions.get(state.name());
> 
> I think either get both state and transition id as parameters, or supply the availableTransitions map as a parameter. I don't think we should store it as a field.

Is there any reason that we can't store it as field?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2279563546

From erikj at openjdk.org  Fri Aug 15 19:49:39 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 15 Aug 2025 19:49:39 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <3Ci3qtpjWdKI5xYZS2OJb5el6yOtb8VUkercfkcw_BQ=.bce14740-dc8b-44f6-84ac-061e8aed9606@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
 <qV1z66K5N1OmEtnXNYtG-CD1KhAAVrZefvTYfZjP2QI=.283e6410-3482-40bc-ac4b-8fc3bdeea2db@github.com>
 <3Ci3qtpjWdKI5xYZS2OJb5el6yOtb8VUkercfkcw_BQ=.bce14740-dc8b-44f6-84ac-061e8aed9606@github.com>
Message-ID: <g8dDcBj4S6-IBZdJp88i4MqZmSMaMvx_3COVTMwwY6s=.08c109a3-45b9-47cf-b2ca-fcd6775f3c7b@github.com>

On Fri, 15 Aug 2025 17:37:41 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 248:
>> 
>>> 246: 
>>> 247:     private void performTransition(JiraIssueState state) {
>>> 248:         var id = availableTransitions.get(state.name());
>> 
>> I think either get both state and transition id as parameters, or supply the availableTransitions map as a parameter. I don't think we should store it as a field.
>
> Is there any reason that we can't store it as field?

I agree that in this particular case, a field would work fine, but in general it's a more brittle solution that I would like to avoid when possible. Storing state in an object creates potential opportunities for races, and forces you to have to think about side effects when calling a method that modifies fields.

In this case it could be argued that the field just acts like a cache, but there aren't enough opportunities for hitting the cache that couldn't easily be solved without a field (since the only user would be a private method that is only called from one other method anyway). If we wanted to cache this value, I would be more comfortable if there was a method to call that handled the caching mechanism in a single place. Something like `availableTransitions(boolean useCachedValue)`, but as I said, I think it's overkill here.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2279765811

From zsong at openjdk.org  Fri Aug 15 19:58:53 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 15 Aug 2025 19:58:53 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]
In-Reply-To: <g8dDcBj4S6-IBZdJp88i4MqZmSMaMvx_3COVTMwwY6s=.08c109a3-45b9-47cf-b2ca-fcd6775f3c7b@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <tHntzIXdt0fampffDXcyKWWR6EhjZnszPIsMmj72mmw=.60aa8a61-cf69-4128-a022-d4b3e34163c6@github.com>
 <qV1z66K5N1OmEtnXNYtG-CD1KhAAVrZefvTYfZjP2QI=.283e6410-3482-40bc-ac4b-8fc3bdeea2db@github.com>
 <3Ci3qtpjWdKI5xYZS2OJb5el6yOtb8VUkercfkcw_BQ=.bce14740-dc8b-44f6-84ac-061e8aed9606@github.com>
 <g8dDcBj4S6-IBZdJp88i4MqZmSMaMvx_3COVTMwwY6s=.08c109a3-45b9-47cf-b2ca-fcd6775f3c7b@github.com>
Message-ID: <kYEt1R3ygYhAbfkhAp0usFeRpOjVBBdQmJQE_TeWB90=.bc5206d1-7e83-4dd5-adfc-4df066ecb06a@github.com>

On Fri, 15 Aug 2025 19:47:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Is there any reason that we can't store it as field?
>
> I agree that in this particular case, a field would work fine, but in general it's a more brittle solution that I would like to avoid when possible. Storing state in an object creates potential opportunities for races, and forces you to have to think about side effects when calling a method that modifies fields.
> 
> In this case it could be argued that the field just acts like a cache, but there aren't enough opportunities for hitting the cache that couldn't easily be solved without a field (since the only user would be a private method that is only called from one other method anyway). If we wanted to cache this value, I would be more comfortable if there was a method to call that handled the caching mechanism in a single place. Something like `availableTransitions(boolean useCachedValue)`, but as I said, I think it's overkill here.

Makes sense to me, Thanks for the explanation. Will change it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2279783195

From zsong at openjdk.org  Fri Aug 15 20:53:29 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 15 Aug 2025 20:53:29 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v4]
In-Reply-To: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
Message-ID: <m5OyVO2G1dr-TXT6nux0-DggJDUr7NMho1GN3Bpvqwc=.63cc7276-0f98-4f69-b29f-abae61a77dcc@github.com>

> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1730/files
  - new: https://git.openjdk.org/skara/pull/1730/files/c4e635fb..0cdbae3c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=03
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1730&range=02-03

  Stats: 8 lines in 1 file changed: 0 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/skara/pull/1730.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1730/head:pull/1730

PR: https://git.openjdk.org/skara/pull/1730

From erikj at openjdk.org  Fri Aug 15 23:12:05 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 15 Aug 2025 23:12:05 GMT
Subject: RFR: 2557: Set resolution to Fixed when resolving Jira issues [v4]
In-Reply-To: <m5OyVO2G1dr-TXT6nux0-DggJDUr7NMho1GN3Bpvqwc=.63cc7276-0f98-4f69-b29f-abae61a77dcc@github.com>
References: <_z1bhc_wS6eSEyAVILrcpnYvZD4-WRs4DEwAx7LaE54=.583b81d2-cda9-493b-9b2b-4055d8d4db7c@github.com>
 <m5OyVO2G1dr-TXT6nux0-DggJDUr7NMho1GN3Bpvqwc=.63cc7276-0f98-4f69-b29f-abae61a77dcc@github.com>
Message-ID: <AdqmrGZS0Xf3448GHFZpNlnVHq4c-OBwJk0rypCSeko=.d3cb6b56-91e1-4461-b079-9c7d539328be@github.com>

On Fri, 15 Aug 2025 20:53:29 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1730#pullrequestreview-3125330973