RFR: 2556: LablerWorkItem adds unnecessary overhead when the bot restarts [v2]

Zhao Song zsong at openjdk.org
Wed Aug 6 22:04:36 UTC 2025


> In [SKARA-2408](https://bugs.openjdk.org/browse/SKARA-2408) and [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), I updated the bot to do one more CheckWorkItem with force update after a pr is marked as auto labeled.
> 
> Currently, when the pr bot restarts, the bot would schedule a PullRequestCommandWorkItem for every pr(including closed prs), in the end of PullRequestCommandWorkItem, a LabelerWorkItem will be scheduled for each pr as well. In the LabelerWorkItem, when it finds the bot doesn't have label configuration, the bot will mark the pr as auto labelled and schedule a CheckWorkItem with forceUpdate. This is the issue, the bot shouldn't schedule any CheckWorkItem when the bot doesn't have label configuration. Otherwise, the bot would re-evaluate all the prs with forceUpdate.
> 
> Also, if the pr is already closed, the LabelerWorkItem shouldn't schedule any CheckWorkItem for it.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1729/files
  - new: https://git.openjdk.org/skara/pull/1729/files/7d4aa190..072997bf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1729&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1729&range=00-01

  Stats: 18 lines in 2 files changed: 9 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1729.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1729/head:pull/1729

PR: https://git.openjdk.org/skara/pull/1729


More information about the skara-dev mailing list