RFR: 2557: Set resolution to Fixed when resolving Jira issues
Zhao Song
zsong at openjdk.org
Thu Aug 7 21:44:19 UTC 2025
On Thu, 7 Aug 2025 21:32:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> I think this change warrants a new manual integration test.
I did it but didn't commit the change, will do.
> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 246:
>
>> 244: .put("transition", JSON.object()
>> 245: .put("id", id));
>> 246: if (state.equals("RESOLVED")) {
>
> This method is called with `"Resolved"` not `"RESOLVED"`. To avoid relying on string comparisons here, could we make all the calls to this method use constants, or perhaps even an internal enum?
Sure
-------------
PR Comment: https://git.openjdk.org/skara/pull/1730#issuecomment-3165847337
PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2261475102
More information about the skara-dev
mailing list