RFR: 2557: Set resolution to Fixed when resolving Jira issues [v3]

Zhao Song zsong at openjdk.org
Fri Aug 15 17:40:15 UTC 2025


On Fri, 15 Aug 2025 17:32:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update
>>  - rename method
>
> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 248:
> 
>> 246: 
>> 247:     private void performTransition(JiraIssueState state) {
>> 248:         var id = availableTransitions.get(state.name());
> 
> I think either get both state and transition id as parameters, or supply the availableTransitions map as a parameter. I don't think we should store it as a field.

Is there any reason that we can't store it as field?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2279563546


More information about the skara-dev mailing list