RFR: 2566: When rfr is pending on other workItems, the pr bot shouldn't actively remove the label

[Erik Joelsson]

On Wed, 20 Aug 2025 22:41:28 GMT, Zhao Song <zsong at openjdk.org> wrote:

> I restarted the pr bot today and a user reported that the pr bot removed 'rfr' label on a pull request. It's the side effect of [SKARA-2552](https://bugs.openjdk.org/browse/SKARA-2552), when the bot was evaluating the pull request, the labelerWorkItem wasn't done, so rfrPendingOnOtherWorkItems was set to true. In this case, the bot should just not add 'rfr' label, but not actively remove the 'rfr' label

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 479:

> 477:         if (rfrPendingOnOtherWorkItems) {
> 478:             log.info("rfr is pending on other workItems for pr: " + pr.id());
> 479:             return newLabels.contains("rfr");

I think there is still a case that needs to be fixed here. If `visitor.isReadyForReview()` returns false, we still want to remove `rfr` even if we are waiting on other work items. Or am I missing something?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1732#discussion_r2291005747