RFR: 2065: Update PR labels when new files are touched

[Zhao Song]

On Wed, 27 Aug 2025 20:51:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I understand wanting to optimize for performance by putting this in CheckRun, but it really comes at a cost of maintainability IMO. Having two different WorkItems share the responsibility of adding labels in different situations seems bad. We also have the race situation between labels and comment which isn't easily solved in a nice way within CheckRun.
> 
> Are you sure we would need to spawn another CheckWorkItem after the labeler has run? I can see that it would be forced if `rfr` wasn't set yet and that it would be triggered if we actually added a label, but for most situations where nothing changed, the only thing that would happen is that a comment got updated. That comment would have the bot user as author, and those are filtered out already for the updated check, aren't they? I may be missing something.
> 
> If we do this in the LabelerWorkItem, we can more easily control the order of label changes and comment update, to avoid the risk of inconsistent states.

Yeah, I was thinking the same, we need another run after the label is added, now I am agree with you, seems like it's not that expensive. I will move the logic to LabelerWorkItem. Thanks!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1735#issuecomment-3229732209