RFR: 2065: Update PR labels when new files are touched [v2]
Zhao Song
zsong at openjdk.org
Thu Aug 28 21:45:58 UTC 2025
On Thu, 28 Aug 2025 21:26:42 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with six additional commits since the last revision:
>>
>> - update
>> - update
>> - update
>> - update
>> - update
>> - review comment
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 198:
>
>> 196:
>> 197: if (!pr.isClosed()) {
>> 198: return List.of(new LabelerWorkItem(bot, prId, errorHandler, triggerUpdatedAt));
>
> At this stage in PullRequestCommandWorkItem, we have already loaded all PR comments, so I think it would be worth checking if there is any need for scheduling a LabelerWorkItem. What I mean is, we can check if the head hash of the PR is different from the last labeler commit marker. This could be implemented in a static method on `LabelereWorkItem` to keep the details in one place.
When I was working on it, I have the same thought with you, I added the check and did some tests, later I found there is a case which is that the user use the "/label" command to add the label, in this case, we need LabelerWorkItem to check whether the labels can be upgraded to group labels.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1735#discussion_r2308616069
More information about the skara-dev
mailing list