RFR: 2065: Update PR labels when new files are touched [v2]
Erik Joelsson
erikj at openjdk.org
Thu Aug 28 22:43:45 UTC 2025
On Thu, 28 Aug 2025 22:02:06 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> When I was working on it, I have the same thought with you, I added the check and did some tests, later I found there is a case which is that the user use the "/label" command to add the label, in this case, we need LabelerWorkItem to check whether the labels can be upgraded to group labels.
>
> Or there is another Option, we can add the check here. And in pullRequestWorkItem, after processing a label command, we can schedule a LabelerWorkItem
Hm, that could work, but it would also mean that we need to schedule an initial LabelerWorkItem when bot is starting up, or rather, we need to let the very first one through regardless of commit hash. This is in case a LabelCommand was issued and handled right before bot was restarted.
The alternative would be to compare dates on comments. If the label "command handled" comment has a later date than the last update of the auto labeler comment, then we need to run. If we do that, then the labeler needs to always touch the comment to mark when it was last run. Not sure which is best. If we end up spawning a lot of LabelereWorkItems, it could turn into a lot of comment updates.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1735#discussion_r2308699916
More information about the skara-dev
mailing list