RFR: 2065: Update PR labels when new files are touched [v4]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Aug 29 17:27:29 UTC 2025
On Thu, 28 Aug 2025 23:04:05 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> This patch is trying to make the pr bot be able to update PR labels when new files are touched.
>> The main idea is from Erik. For a new PR, the bot will run a labelerWorkItem to auto label the PR first, and the commit hash will be stored in a comment.
>>
>> With this patch, here are some new behaviors of the bot:
>> (1) The user didn't issue manual label command before auto labeling, LabelerWorkItem will do the initial auto labeling and store the commit hash in the comment.
>> (2) If the user issued manual label command before auto labeling, the initial auto labeling will be skipped, the bot would still post a comment and store the hash in the comment.
>> (3) The user pushes a new commit or few commits to a pr that already auto labeled, the bot will evaluate the diff between stored hash and current head, then add new labels or upgrading labels to group labels, in the end, update the stored hash in the comment.
>> (4) The user force pushes to the pr that already auto labeled, the bot will evaluate the diff between baseHash and current head.
>> (5) The user issues a command to add a label to the pr(or even the user add the label via the forge UI), the bot will check if the labels can be upgraded to group labels.
>>
>> The side effect of this feature I can imagine is that a user thinks a file is not related to a component and removed it manually, but later, every time when he touches the file, the label will be added back.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> review comment
I don't think there is a reason to have a command to disable the autolabeler. It is unlikely that it will work so badly that you want to turn it off for a PR. That would be a situation where you like keep adding files that the labeler keep misclassifying. If that would exceed the annoyance threshold for the users, the autolabeler rules should be fixed instead.
-------------
PR Comment: https://git.openjdk.org/skara/pull/1735#issuecomment-3237726982
More information about the skara-dev
mailing list