From erikj at openjdk.org Mon Dec 1 23:30:26 2025 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 1 Dec 2025 23:30:26 GMT Subject: Integrated: 2610: Mailman 3 support In-Reply-To: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com> References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com> Message-ID: On Fri, 21 Nov 2025 23:14:50 GMT, Erik Joelsson wrote: > The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes > > ### 1. REST API > The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. > > The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. > > ### 2. Mbox format > The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed. > > Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. > > An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara. > > This is a big patch, so sorry in advance. This pull request has now been integrated. Changeset: db92d060 Author: Erik Joelsson URL: https://git.openjdk.org/skara/commit/db92d06064a5b4dbe9403663669c7dc47560220e Stats: 1451 lines in 23 files changed: 1061 ins; 232 del; 158 mod 2610: Mailman 3 support Reviewed-by: zsong ------------- PR: https://git.openjdk.org/skara/pull/1743 From dnsimon at openjdk.org Tue Dec 2 09:17:07 2025 From: dnsimon at openjdk.org (Doug Simon) Date: Tue, 2 Dec 2025 09:17:07 GMT Subject: RFR: 2630: Remove graal-dev list Message-ID: This removes graal-dev as a watcher of various openjdk directories. ------------- Commit messages: - remove graal mailing list matchers Changes: https://git.openjdk.org/skara/pull/1745/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1745&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2630 Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1745.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1745/head:pull/1745 PR: https://git.openjdk.org/skara/pull/1745 From zsong at openjdk.org Tue Dec 2 17:31:07 2025 From: zsong at openjdk.org (Zhao Song) Date: Tue, 2 Dec 2025 17:31:07 GMT Subject: RFR: 2630: Remove graal-dev list In-Reply-To: References: Message-ID: On Tue, 2 Dec 2025 09:07:36 GMT, Doug Simon wrote: > This removes graal-dev as a watcher of various openjdk directories. Marked as reviewed by zsong (Reviewer). ------------- PR Review: https://git.openjdk.org/skara/pull/1745#pullrequestreview-3531347283 From iris at openjdk.org Tue Dec 2 17:36:26 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 2 Dec 2025 17:36:26 GMT Subject: RFR: 2630: Remove graal-dev list In-Reply-To: References: Message-ID: <7ocDyAe8dgDdX3DK0kELdv4j1zEnTYzfpn7-WN8Wzsk=.a8da8b76-c66a-4f2a-8380-4deadf8772a6@github.com> On Tue, 2 Dec 2025 09:07:36 GMT, Doug Simon wrote: > This removes graal-dev as a watcher of various openjdk directories. Marked as reviewed by iris (no project role). ------------- PR Review: https://git.openjdk.org/skara/pull/1745#pullrequestreview-3531366221 From duke at openjdk.org Tue Dec 2 17:46:56 2025 From: duke at openjdk.org (duke) Date: Tue, 2 Dec 2025 17:46:56 GMT Subject: RFR: 2630: Remove graal-dev list In-Reply-To: References: Message-ID: <7uBgyRU9Z6I3oNTgGNcifOvsvq5zPuWWvI9pZR18kOQ=.b7d5701b-f42b-41be-8344-0f4b4f8b33b0@github.com> On Tue, 2 Dec 2025 09:07:36 GMT, Doug Simon wrote: > This removes graal-dev as a watcher of various openjdk directories. @dougxc Your change (at version bee8ec992a1ebbb31618c96c5926faacd8260f4f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/skara/pull/1745#issuecomment-3603253152 From dnsimon at openjdk.org Tue Dec 2 17:54:20 2025 From: dnsimon at openjdk.org (Doug Simon) Date: Tue, 2 Dec 2025 17:54:20 GMT Subject: Integrated: 2630: Remove graal-dev list In-Reply-To: References: Message-ID: On Tue, 2 Dec 2025 09:07:36 GMT, Doug Simon wrote: > This removes graal-dev as a watcher of various openjdk directories. This pull request has now been integrated. Changeset: cfb032c4 Author: Doug Simon Committer: Zhao Song URL: https://git.openjdk.org/skara/commit/cfb032c4626d69817053056aaebb77b0c27c9180 Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod 2630: Remove graal-dev list Reviewed-by: zsong, iris ------------- PR: https://git.openjdk.org/skara/pull/1745